From 28ab129d4243db7e680bb85e2ea663774b381168 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Thu, 19 Mar 2020 12:51:08 -0400 Subject: [PATCH 1/8] Move vpshere model to GA. --- go.mod | 3 ++- metricbeat/docs/modules/vsphere.asciidoc | 2 -- metricbeat/docs/modules/vsphere/datastore.asciidoc | 2 -- metricbeat/docs/modules/vsphere/host.asciidoc | 2 -- metricbeat/docs/modules/vsphere/virtualmachine.asciidoc | 2 -- metricbeat/docs/modules_list.asciidoc | 8 ++++---- metricbeat/module/vsphere/_meta/fields.yml | 2 +- metricbeat/module/vsphere/datastore/_meta/fields.yml | 2 +- metricbeat/module/vsphere/fields.go | 2 +- metricbeat/module/vsphere/host/_meta/fields.yml | 2 +- metricbeat/module/vsphere/virtualmachine/_meta/fields.yml | 2 +- 11 files changed, 11 insertions(+), 18 deletions(-) diff --git a/go.mod b/go.mod index 280fc6a2675..058deae7f3b 100644 --- a/go.mod +++ b/go.mod @@ -46,6 +46,7 @@ require ( github.com/dgrijalva/jwt-go v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible // indirect github.com/digitalocean/go-libvirt v0.0.0-20180301200012-6075ea3c39a1 github.com/dlclark/regexp2 v1.1.7-0.20171009020623-7632a260cbaf // indirect + github.com/docker/distribution v2.7.1+incompatible github.com/docker/docker v1.4.2-0.20170802015333-8af4db6f002a github.com/docker/go-connections v0.4.0 github.com/docker/go-metrics v0.0.1 // indirect @@ -116,7 +117,7 @@ require ( github.com/mitchellh/mapstructure v1.1.2 github.com/morikuni/aec v1.0.0 // indirect github.com/oklog/ulid v1.3.1 - github.com/opencontainers/go-digest v1.0.0-rc1.0.20190228220655-ac19fd6e7483 // indirect + github.com/opencontainers/go-digest v1.0.0-rc1.0.20190228220655-ac19fd6e7483 github.com/opencontainers/image-spec v1.0.2-0.20190823105129-775207bd45b6 // indirect github.com/pierrre/gotestcover v0.0.0-20160113212533-7b94f124d338 github.com/pkg/errors v0.9.1 diff --git a/metricbeat/docs/modules/vsphere.asciidoc b/metricbeat/docs/modules/vsphere.asciidoc index b426ea76ba9..638c9f9d5d7 100644 --- a/metricbeat/docs/modules/vsphere.asciidoc +++ b/metricbeat/docs/modules/vsphere.asciidoc @@ -5,8 +5,6 @@ This file is generated! See scripts/mage/docs_collector.go [[metricbeat-module-vsphere]] == vSphere module -beta[] - The vSphere module uses the https://github.com/vmware/govmomi[Govmomi] library to collect metrics from any Vmware SDK URL (ESXi/VCenter). This library is built for and tested against ESXi and vCenter 5.5, 6.0 and 6.5. By default it enables the metricsets `datastore`, `host` and `virtualmachine`. diff --git a/metricbeat/docs/modules/vsphere/datastore.asciidoc b/metricbeat/docs/modules/vsphere/datastore.asciidoc index 7b68437b5ce..dff7ab78546 100644 --- a/metricbeat/docs/modules/vsphere/datastore.asciidoc +++ b/metricbeat/docs/modules/vsphere/datastore.asciidoc @@ -5,8 +5,6 @@ This file is generated! See scripts/mage/docs_collector.go [[metricbeat-metricset-vsphere-datastore]] === vSphere datastore metricset -beta[] - include::../../../module/vsphere/datastore/_meta/docs.asciidoc[] This is a default metricset. If the host module is unconfigured, this metricset is enabled by default. diff --git a/metricbeat/docs/modules/vsphere/host.asciidoc b/metricbeat/docs/modules/vsphere/host.asciidoc index 583bdb2e4e6..1f8bb0ead34 100644 --- a/metricbeat/docs/modules/vsphere/host.asciidoc +++ b/metricbeat/docs/modules/vsphere/host.asciidoc @@ -5,8 +5,6 @@ This file is generated! See scripts/mage/docs_collector.go [[metricbeat-metricset-vsphere-host]] === vSphere host metricset -beta[] - include::../../../module/vsphere/host/_meta/docs.asciidoc[] This is a default metricset. If the host module is unconfigured, this metricset is enabled by default. diff --git a/metricbeat/docs/modules/vsphere/virtualmachine.asciidoc b/metricbeat/docs/modules/vsphere/virtualmachine.asciidoc index 59ac57af1f6..edeabb47134 100644 --- a/metricbeat/docs/modules/vsphere/virtualmachine.asciidoc +++ b/metricbeat/docs/modules/vsphere/virtualmachine.asciidoc @@ -5,8 +5,6 @@ This file is generated! See scripts/mage/docs_collector.go [[metricbeat-metricset-vsphere-virtualmachine]] === vSphere virtualmachine metricset -beta[] - include::../../../module/vsphere/virtualmachine/_meta/docs.asciidoc[] This is a default metricset. If the host module is unconfigured, this metricset is enabled by default. diff --git a/metricbeat/docs/modules_list.asciidoc b/metricbeat/docs/modules_list.asciidoc index 7cddba02d9c..0365d5b0f2d 100644 --- a/metricbeat/docs/modules_list.asciidoc +++ b/metricbeat/docs/modules_list.asciidoc @@ -258,10 +258,10 @@ This file is generated! See scripts/mage/docs_collector.go .1+| .1+| |<> |<> |image:./images/icon-yes.png[Prebuilt dashboards are available] | .1+| .1+| |<> -|<> beta[] |image:./images/icon-yes.png[Prebuilt dashboards are available] | -.3+| .3+| |<> beta[] -|<> beta[] -|<> beta[] +|<> |image:./images/icon-yes.png[Prebuilt dashboards are available] | +.3+| .3+| |<> +|<> +|<> |<> |image:./images/icon-yes.png[Prebuilt dashboards are available] | .2+| .2+| |<> beta[] |<> diff --git a/metricbeat/module/vsphere/_meta/fields.yml b/metricbeat/module/vsphere/_meta/fields.yml index 1c3503fbd3f..63cdb9a843e 100644 --- a/metricbeat/module/vsphere/_meta/fields.yml +++ b/metricbeat/module/vsphere/_meta/fields.yml @@ -2,7 +2,7 @@ title: "vSphere" description: > vSphere module - release: beta + release: ga fields: - name: vsphere type: group diff --git a/metricbeat/module/vsphere/datastore/_meta/fields.yml b/metricbeat/module/vsphere/datastore/_meta/fields.yml index f9545509cae..7a1ff578e3f 100644 --- a/metricbeat/module/vsphere/datastore/_meta/fields.yml +++ b/metricbeat/module/vsphere/datastore/_meta/fields.yml @@ -2,7 +2,7 @@ type: group description: > datastore - release: beta + release: ga fields: - name: name type: keyword diff --git a/metricbeat/module/vsphere/fields.go b/metricbeat/module/vsphere/fields.go index cf49cbee27f..1490fb00f37 100644 --- a/metricbeat/module/vsphere/fields.go +++ b/metricbeat/module/vsphere/fields.go @@ -32,5 +32,5 @@ func init() { // AssetVsphere returns asset data. // This is the base64 encoded gzipped contents of ../metricbeat/module/vsphere. func AssetVsphere() string { - return "eJzMlsFunDAQhu/7FKPcsw/AoZdUaS/bVkrT68oLw+IuxpY9JKJPX9mGFRjTpMG08WGlteH/PzDzj2/hgl0GT0ZVqHEHQJxqzODm6cHN3OwACjS55oq4bDL4sAMA6FdByKKt7W0aa2QGMzghsR1AybEuTOYuvoWGCRyb2EGdwgzOWraqn4n4TIXGYgUjZkhe5eKSi7L9UkQkfJJhhCBjGPs7WRhYLtg9S10Ea38gsuPjQDXXHQxLY/XTWd7zGk1nCAXMhAfPnCmWc+r2JInV+1NHaKIEtWzOf2f/3SqCUwRZAlUY3Ro7SqkFowzm9jPOUiMmxbzXiMkpW4NFUspHg8U2lCqnlIwKdY4NvZayv/y6OouEShpakwbB/f8/CD5LQ8sZkKvWb4uofqXclrtvj8AbOASqY1ufAOl8ff2/wtiVdDpfV9Av2AoUUm9Vpgcnbu1j0i/XZw+3VSInwtsmiNfCNUjPUl+O9l8c7E1F+8XLwlT2egbimlpWC5ZXvFl1dllUektu2ejb8/BJ10ZXIDgxsz8bpeXQUII83yqlf/iNgIPfieXAlgm/stD0q0LNiDdnePDHuPfWNsYxem7R0GZhKkv4ZA1Wx5ZjdR/rhqi+UJLkf/rXOukCyd6rawfpYcdNYT1r3hqS4uhDM0ooTz9xdiD2k8cVlX3njCFi/E8b1+8AAAD//7eBEp0=" + return "eJzMls1u2zoQhfd+ikH28QNocTe5SLtxWyBNtwYjjSzWooYgRwnUpy9ISoZ+6CapqLZcGLBInfNJ1JzhLZyxy+DZ6goN7gBYco0Z3Dw/+Cs3O4ACbW6kZklNBv/tAAD6WVBUtLW7zWCNwmIGJ7EDKCXWhc380ltohMKxhRvcabfYUKv7KxGXqdBYrBAsLNNFLi55VbafiohMn2MYc4wxivudTAwkZ+xeyBSzuV/wuPH/wLTUHQxL6/TTWd7LGm1nGRUshAfPXGiRS+72TCzq/VPHaKMENTWn99l/dYrgFYFK4AqjG+NGSUYJzmBpv+AsDWJSzHuDmJyytVgkpXy0WGxDqXNOyajR5NjwWyn75ZfZRSBUZHlNFszu/9sx8JEsX0+AXLdhU1T1I+Wm3H15BNnAYaY6tg31n843VP8bjH1Bp/P15fyKrUJFZqsiPXhxZx+Tfr06e7it8jgR3jYxvBauQX4hcz66f3Gw3yraT0EWprKX84803IpaibySzapzy1Wl96eWi729nD/n2uCaCU7M3M9GWTk0k1mWb5XR38I2wCHsw/W4poTf2Nz0s0YjWDYneAhHuH+taYxD9NSi5c2ilEr44AxWh5Zn9R/rhqihUJKkf/rXOukByd6rbwbpYcctYT1r3lomdQyhGSWkp++4OAyHi8cVlX3njSFi/Efb1s8AAAD//5A1D00=" } diff --git a/metricbeat/module/vsphere/host/_meta/fields.yml b/metricbeat/module/vsphere/host/_meta/fields.yml index 5cbbc310d05..ef6331082eb 100644 --- a/metricbeat/module/vsphere/host/_meta/fields.yml +++ b/metricbeat/module/vsphere/host/_meta/fields.yml @@ -2,7 +2,7 @@ type: group description: > host - release: beta + release: ga fields: - name: name type: keyword diff --git a/metricbeat/module/vsphere/virtualmachine/_meta/fields.yml b/metricbeat/module/vsphere/virtualmachine/_meta/fields.yml index f7bc14d856f..fbbbeec5691 100644 --- a/metricbeat/module/vsphere/virtualmachine/_meta/fields.yml +++ b/metricbeat/module/vsphere/virtualmachine/_meta/fields.yml @@ -2,7 +2,7 @@ type: group description: > virtualmachine - release: beta + release: ga fields: - name: host.id type: keyword From cb7cd2f07e70b8ccbed8b59f0a44fba7271c00c7 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Thu, 19 Mar 2020 13:03:40 -0400 Subject: [PATCH 2/8] Revert go.mod --- go.mod | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/go.mod b/go.mod index 058deae7f3b..280fc6a2675 100644 --- a/go.mod +++ b/go.mod @@ -46,7 +46,6 @@ require ( github.com/dgrijalva/jwt-go v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible // indirect github.com/digitalocean/go-libvirt v0.0.0-20180301200012-6075ea3c39a1 github.com/dlclark/regexp2 v1.1.7-0.20171009020623-7632a260cbaf // indirect - github.com/docker/distribution v2.7.1+incompatible github.com/docker/docker v1.4.2-0.20170802015333-8af4db6f002a github.com/docker/go-connections v0.4.0 github.com/docker/go-metrics v0.0.1 // indirect @@ -117,7 +116,7 @@ require ( github.com/mitchellh/mapstructure v1.1.2 github.com/morikuni/aec v1.0.0 // indirect github.com/oklog/ulid v1.3.1 - github.com/opencontainers/go-digest v1.0.0-rc1.0.20190228220655-ac19fd6e7483 + github.com/opencontainers/go-digest v1.0.0-rc1.0.20190228220655-ac19fd6e7483 // indirect github.com/opencontainers/image-spec v1.0.2-0.20190823105129-775207bd45b6 // indirect github.com/pierrre/gotestcover v0.0.0-20160113212533-7b94f124d338 github.com/pkg/errors v0.9.1 From 914da1583c470cd2583a2388f7822b5fa2491fd8 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Thu, 19 Mar 2020 13:05:34 -0400 Subject: [PATCH 3/8] Update changelog. --- CHANGELOG.next.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc index 44bcd78c384..6b74dff0514 100644 --- a/CHANGELOG.next.asciidoc +++ b/CHANGELOG.next.asciidoc @@ -262,6 +262,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d - Add support for CouchDB v2 {issue}16352[16352] {pull}16455[16455] - Replace vpc metricset into vpn, transitgateway and natgateway metricsets. {pull}16892[16892] - Release Oracle module as GA. {issue}14279[14279] {pull}16833[16833] +- Release vsphere module as GA. {issue}15798[15798] {pull}17119[17119] *Packetbeat* From 5e579d86113a5d0172d74e151b05c6f4bd4d96aa Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Thu, 19 Mar 2020 14:25:32 -0400 Subject: [PATCH 4/8] Add integration test. --- metricbeat/module/vsphere/_meta/Dockerfile | 6 ++ metricbeat/module/vsphere/docker-compose.yml | 11 +++ metricbeat/module/vsphere/test_vsphere.py | 86 ++++++++++++++++++++ 3 files changed, 103 insertions(+) create mode 100644 metricbeat/module/vsphere/_meta/Dockerfile create mode 100644 metricbeat/module/vsphere/docker-compose.yml create mode 100644 metricbeat/module/vsphere/test_vsphere.py diff --git a/metricbeat/module/vsphere/_meta/Dockerfile b/metricbeat/module/vsphere/_meta/Dockerfile new file mode 100644 index 00000000000..c7875267af0 --- /dev/null +++ b/metricbeat/module/vsphere/_meta/Dockerfile @@ -0,0 +1,6 @@ +ARG VSPHERE_GOLANG_VERSION +FROM golang:${VSPHERE_GOLANG_VERSION}-alpine + +RUN apk add --no-cache git +RUN go get -u github.com/vmware/govmomi/vcsim +CMD vcsim -l :8989 diff --git a/metricbeat/module/vsphere/docker-compose.yml b/metricbeat/module/vsphere/docker-compose.yml new file mode 100644 index 00000000000..bbe0b6ab030 --- /dev/null +++ b/metricbeat/module/vsphere/docker-compose.yml @@ -0,0 +1,11 @@ +version: '2.3' + +services: + vpshere: + image: docker.elastic.co/integrations-ci/beats-vsphere:${VSPHERE_GOLANG_VERSION:-1.14}-1 + build: + context: ./_meta + args: + VSPHERE_GOLANG_VERSION: ${VSPHERE_GOLANG_VERSION:-1.14} + ports: + - 8989 diff --git a/metricbeat/module/vsphere/test_vsphere.py b/metricbeat/module/vsphere/test_vsphere.py new file mode 100644 index 00000000000..dce73da5871 --- /dev/null +++ b/metricbeat/module/vsphere/test_vsphere.py @@ -0,0 +1,86 @@ +import os +import sys +import unittest + +sys.path.append(os.path.join(os.path.dirname(__file__), '../../tests/system')) +import metricbeat + + +VSPHERE_FIELDS = metricbeat.COMMON_FIELDS + ["vsphere"] + + +@metricbeat.parameterized_with_supported_versions +class TestVsphere(metricbeat.BaseTest): + COMPOSE_SERVICES = ['vsphere'] + + @unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test") + def test_datastore(self): + """ + vsphere datastore test + """ + self.render_config_template(modules=[{ + "name": "vsphere", + "metricsets": ["datastore"], + "hosts": self.get_hosts(), + "period": "5s", + }]) + proc = self.start_beat() + self.wait_until(lambda: self.output_lines() > 0) + proc.check_kill_and_wait() + self.assert_no_logged_warnings() + + output = self.read_output_json() + self.assertEqual(len(output), 1) + evt = output[0] + + self.assertCountEqual(self.de_dot(VSPHERE_FIELDS), evt.keys(), evt) + + self.assert_fields_are_documented(evt) + + @unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test") + def test_host(self): + """ + vsphere host test + """ + self.render_config_template(modules=[{ + "name": "vsphere", + "metricsets": ["host"], + "hosts": self.get_hosts(), + "period": "5s", + }]) + proc = self.start_beat() + self.wait_until(lambda: self.output_lines() > 0) + proc.check_kill_and_wait() + self.assert_no_logged_warnings() + + output = self.read_output_json() + self.assertEqual(len(output), 1) + evt = output[0] + + self.assertCountEqual(self.de_dot(VSPHERE_FIELDS), evt.keys(), evt) + + self.assert_fields_are_documented(evt) + + @unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test") + def test_virtualmachine(self): + """ + vsphere virtualmachine test + """ + self.render_config_template(modules=[{ + "name": "vsphere", + "metricsets": ["virtualmachine"], + "hosts": self.get_hosts(), + "period": "5s", + }]) + proc = self.start_beat() + self.wait_until(lambda: self.output_lines() > 0) + proc.check_kill_and_wait() + self.assert_no_logged_warnings() + + output = self.read_output_json() + self.assertEqual(len(output), 1) + evt = output[0] + + self.assertCountEqual(self.de_dot(VSPHERE_FIELDS), evt.keys(), evt) + + self.assert_fields_are_documented(evt) From 560ff77796736bca395d019816b37dee16024b76 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Fri, 20 Mar 2020 10:39:33 -0400 Subject: [PATCH 5/8] Add healthcheck. --- metricbeat/module/vsphere/_meta/Dockerfile | 4 +++- metricbeat/module/vsphere/docker-compose.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/metricbeat/module/vsphere/_meta/Dockerfile b/metricbeat/module/vsphere/_meta/Dockerfile index c7875267af0..0dfa4cbde84 100644 --- a/metricbeat/module/vsphere/_meta/Dockerfile +++ b/metricbeat/module/vsphere/_meta/Dockerfile @@ -1,6 +1,8 @@ ARG VSPHERE_GOLANG_VERSION FROM golang:${VSPHERE_GOLANG_VERSION}-alpine -RUN apk add --no-cache git +RUN apk add --no-cache curl git RUN go get -u github.com/vmware/govmomi/vcsim + +HEALTHCHECK --interval=1s --retries=60 --timeout=10s CMD curl http://localhost:8989/ CMD vcsim -l :8989 diff --git a/metricbeat/module/vsphere/docker-compose.yml b/metricbeat/module/vsphere/docker-compose.yml index bbe0b6ab030..8037b6458f2 100644 --- a/metricbeat/module/vsphere/docker-compose.yml +++ b/metricbeat/module/vsphere/docker-compose.yml @@ -1,7 +1,7 @@ version: '2.3' services: - vpshere: + vsphere: image: docker.elastic.co/integrations-ci/beats-vsphere:${VSPHERE_GOLANG_VERSION:-1.14}-1 build: context: ./_meta From c17e82fa059573ce19442a105a533279ec2de695 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Fri, 20 Mar 2020 15:20:39 -0400 Subject: [PATCH 6/8] Fix test. --- metricbeat/module/vsphere/test_vsphere.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/metricbeat/module/vsphere/test_vsphere.py b/metricbeat/module/vsphere/test_vsphere.py index dce73da5871..eea05665ee1 100644 --- a/metricbeat/module/vsphere/test_vsphere.py +++ b/metricbeat/module/vsphere/test_vsphere.py @@ -13,6 +13,10 @@ class TestVsphere(metricbeat.BaseTest): COMPOSE_SERVICES = ['vsphere'] + @classmethod + def get_hosts(cls): + return ['http://{}/sdk'.format(cls.compose_host())] + @unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test") def test_datastore(self): """ @@ -23,6 +27,11 @@ def test_datastore(self): "metricsets": ["datastore"], "hosts": self.get_hosts(), "period": "5s", + "username": "user", + "password": "pass", + "extras": { + "insecure": True, + }, }]) proc = self.start_beat() self.wait_until(lambda: self.output_lines() > 0) @@ -47,6 +56,11 @@ def test_host(self): "metricsets": ["host"], "hosts": self.get_hosts(), "period": "5s", + "username": "user", + "password": "pass", + "extras": { + "insecure": True, + }, }]) proc = self.start_beat() self.wait_until(lambda: self.output_lines() > 0) @@ -71,6 +85,11 @@ def test_virtualmachine(self): "metricsets": ["virtualmachine"], "hosts": self.get_hosts(), "period": "5s", + "username": "user", + "password": "pass", + "extras": { + "insecure": True, + }, }]) proc = self.start_beat() self.wait_until(lambda: self.output_lines() > 0) From eea64376e046d48ce9dc7a7f53998517fa5d500b Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Fri, 20 Mar 2020 19:07:42 -0400 Subject: [PATCH 7/8] Fix tests. --- metricbeat/module/vsphere/test_vsphere.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/metricbeat/module/vsphere/test_vsphere.py b/metricbeat/module/vsphere/test_vsphere.py index eea05665ee1..b9e3e4709e9 100644 --- a/metricbeat/module/vsphere/test_vsphere.py +++ b/metricbeat/module/vsphere/test_vsphere.py @@ -15,7 +15,7 @@ class TestVsphere(metricbeat.BaseTest): @classmethod def get_hosts(cls): - return ['http://{}/sdk'.format(cls.compose_host())] + return ['https://{}/sdk'.format(cls.compose_host())] @unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test") def test_datastore(self): @@ -68,7 +68,7 @@ def test_host(self): self.assert_no_logged_warnings() output = self.read_output_json() - self.assertEqual(len(output), 1) + self.assertEqual(len(output), 4) evt = output[0] self.assertCountEqual(self.de_dot(VSPHERE_FIELDS), evt.keys(), evt) @@ -97,7 +97,7 @@ def test_virtualmachine(self): self.assert_no_logged_warnings() output = self.read_output_json() - self.assertEqual(len(output), 1) + self.assertEqual(len(output), 4) evt = output[0] self.assertCountEqual(self.de_dot(VSPHERE_FIELDS), evt.keys(), evt) From b0be456eab8c05c7ccde02ce4e1d5925b136b978 Mon Sep 17 00:00:00 2001 From: Blake Rouse Date: Tue, 24 Mar 2020 11:24:06 -0400 Subject: [PATCH 8/8] Remove beta cfgwarn. --- metricbeat/module/vsphere/datastore/datastore.go | 3 --- metricbeat/module/vsphere/host/host.go | 3 --- metricbeat/module/vsphere/virtualmachine/virtualmachine.go | 3 --- 3 files changed, 9 deletions(-) diff --git a/metricbeat/module/vsphere/datastore/datastore.go b/metricbeat/module/vsphere/datastore/datastore.go index 44ddb1ac65b..c0699daae77 100644 --- a/metricbeat/module/vsphere/datastore/datastore.go +++ b/metricbeat/module/vsphere/datastore/datastore.go @@ -24,7 +24,6 @@ import ( "github.com/pkg/errors" "github.com/elastic/beats/v7/libbeat/common" - "github.com/elastic/beats/v7/libbeat/common/cfgwarn" "github.com/elastic/beats/v7/metricbeat/mb" "github.com/vmware/govmomi" @@ -47,8 +46,6 @@ type MetricSet struct { // New create a new instance of the MetricSet func New(base mb.BaseMetricSet) (mb.MetricSet, error) { - cfgwarn.Beta("The vsphere datastore metricset is beta") - config := struct { Username string `config:"username"` Password string `config:"password"` diff --git a/metricbeat/module/vsphere/host/host.go b/metricbeat/module/vsphere/host/host.go index 90f5e89a6f7..e8bc5d090bb 100644 --- a/metricbeat/module/vsphere/host/host.go +++ b/metricbeat/module/vsphere/host/host.go @@ -26,7 +26,6 @@ import ( "github.com/pkg/errors" "github.com/elastic/beats/v7/libbeat/common" - "github.com/elastic/beats/v7/libbeat/common/cfgwarn" "github.com/elastic/beats/v7/metricbeat/mb" "github.com/vmware/govmomi" @@ -52,8 +51,6 @@ type MetricSet struct { // New create a new instance of the MetricSet func New(base mb.BaseMetricSet) (mb.MetricSet, error) { - cfgwarn.Beta("The vsphere host metricset is beta") - config := struct { Username string `config:"username"` Password string `config:"password"` diff --git a/metricbeat/module/vsphere/virtualmachine/virtualmachine.go b/metricbeat/module/vsphere/virtualmachine/virtualmachine.go index 5dd2a99675f..82dd9c90ad8 100644 --- a/metricbeat/module/vsphere/virtualmachine/virtualmachine.go +++ b/metricbeat/module/vsphere/virtualmachine/virtualmachine.go @@ -24,7 +24,6 @@ import ( "strings" "github.com/elastic/beats/v7/libbeat/common" - "github.com/elastic/beats/v7/libbeat/common/cfgwarn" "github.com/elastic/beats/v7/metricbeat/mb" "github.com/pkg/errors" @@ -53,8 +52,6 @@ type MetricSet struct { // New create a new instance of the MetricSet func New(base mb.BaseMetricSet) (mb.MetricSet, error) { - cfgwarn.Beta("The vsphere virtualmachine metricset is beta") - config := struct { Username string `config:"username"` Password string `config:"password"`