Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readiness probe not cover left node #4354

Closed
JaydenHan1106 opened this issue Mar 17, 2021 · 1 comment
Closed

readiness probe not cover left node #4354

JaydenHan1106 opened this issue Mar 17, 2021 · 1 comment

Comments

@JaydenHan1106
Copy link

Hi all,
Readiness probe is "Get 9200 port" now. When es node left cluster(such as network problem), readiness probe still return ok, so request still can arrive left node. It's not our expect.

@botelastic botelastic bot added the triage label Mar 17, 2021
@botelastic botelastic bot removed the triage label Mar 30, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Mar 31, 2021

The Elasticsearch readiness probe was designed to:

  • allow for reads without a master
  • improve availability for some search heavy use cases

History of changes on this probe:

  1. /_cat/master => / # increase availiblity and favor search requests (Simplify the readiness check  #617 / PR Simplify ES readiness by requesting / instead of /_cat/master #626)
  2. / => _cat/nodes?local # don't break change budget (Pod readiness based on cluster availability breaks change budget #1748 / PR Bind ES Pod readiness to a node-local endpoint #1777)
  3. _cat/nodes?local => / # don't fail if a single node is stuck (Elasticsearch readiness probe might fail if a single node is stuck #2248 / PR Fix readiness probe #2272)

@thbkrkr thbkrkr closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants