Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Change default index patterns to include Windows forwarded Logs #2415

Closed
patrickrei opened this issue Dec 5, 2022 · 3 comments · Fixed by #2438
Closed

[Rule Tuning] Change default index patterns to include Windows forwarded Logs #2415

patrickrei opened this issue Dec 5, 2022 · 3 comments · Fixed by #2438
Assignees
Labels
backlog community Rule: Tuning tweaking or tuning an existing rule

Comments

@patrickrei
Copy link

patrickrei commented Dec 5, 2022

Link to rule

For example, but applies to several windows rules: https://github.com/elastic/detection-rules/blob/main/rules/windows/credential_access_bruteforce_multiple_logon_failure_same_srcip.toml

Description

The issue is the default index patterns setting index = ["winlogbeat-*", "logs-system.*"]. If you are using Windows Event Forwarding (WEF), collect logs from several machines on a single host and collect them with the Elastic Agent (Windows Integration - Forwarded Event Logs), then the default index patterns does not match as it is logs-windows.forwarded-*. Is it possible to add the index pattern for forwarded Windows logs in the default patterns?

Example Data

No rule logic changes.
Change index = ["winlogbeat-*", "logs-system.*"] to index = ["winlogbeat-*", "logs-system.*", "logs-windows.forwarded-*"]

@patrickrei patrickrei added the Rule: Tuning tweaking or tuning an existing rule label Dec 5, 2022
@patrickrei patrickrei changed the title [Rule Tuning] Name of rule [Rule Tuning] Change default index patterns to include Windows forwarded Logs Dec 5, 2022
@w0rk3r
Copy link
Contributor

w0rk3r commented Dec 5, 2022

Hey @patrickrei, thanks for bringing this for our attention! I'll take a look on this.

@ChriZzn
Copy link

ChriZzn commented Dec 6, 2022

Hi together,

there is another Problem to consider, some rules will still not work because the EQL Query requires the host.id field to be set which is not the case if you use the EventLog Forwarding.
Maybe You consider Here working with just the source.ip or hostname...

Example Rule:
https://github.com/elastic/detection-rules/blob/main/rules/windows/credential_access_bruteforce_multiple_logon_failure_followed_by_success.toml

Regards Christoph

@w0rk3r
Copy link
Contributor

w0rk3r commented Dec 21, 2022

Hey @patrickrei, here is a PR to solve this one: #2438. Feel free to review and/or give us your feedback.

Here is a comment regarding the host.id problem: #2438 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog community Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants