Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add better support for nested structures #64

Open
brokensound77 opened this issue Jul 16, 2020 · 1 comment
Open

[CLI] Add better support for nested structures #64

brokensound77 opened this issue Jul 16, 2020 · 1 comment
Labels
backlog bug Something isn't working cli command line tooling enhancement New feature or request

Comments

@brokensound77
Copy link
Contributor

Describe the bug
The create-rule prompt loop and rule build loop were initially built to support a flat schema, but as the schema has expanded and added nested objects, they can no longer support this. Additionally, the function to detect unneeded default fields is also prone to miss nested data as well.

We will need to refactor the full schema_prompt to be able to recursively prompt for nested data. There is a chance that there could be other pieces of code which also miss the nested structure of rules as well, and so we should review and refactor as needed.

Additional context
@rw-access has some working code to move some of the prompt logic to within click, but we may need to expand nested support.

@brokensound77 brokensound77 added the bug Something isn't working label Jul 16, 2020
@rw-access rw-access added cli command line tooling enhancement New feature or request labels Jul 16, 2020
@rw-access rw-access changed the title [Bug] Add better support for handling nested data within rules [CLI] Add better support for nested structures Aug 20, 2020
@rw-access rw-access removed the bug Something isn't working label Aug 20, 2020
@botelastic
Copy link

botelastic bot commented Aug 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale 60 days of inactivity label Aug 25, 2021
@brokensound77 brokensound77 added the bug Something isn't working label Aug 26, 2021
@botelastic botelastic bot removed the stale 60 days of inactivity label Aug 26, 2021
@Mikaayenson Mikaayenson removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working cli command line tooling enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants