Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Replace Agent's hasKey with EQL's some.field != null #126

Open
ph opened this issue Sep 10, 2020 · 4 comments
Open

[Elastic-Agent] Replace Agent's hasKey with EQL's some.field != null #126

ph opened this issue Sep 10, 2020 · 4 comments
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ph
Copy link
Contributor

ph commented Sep 10, 2020

As noted in elastic/beats#20994 EQL just do some.field != null we should investigate if we could converge on the same syntax.
@ph ph added the enhancement New feature or request label Sep 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph changed the title [Elastic-Agent] EQL hasKey vs some.field [Elastic-Agent] Replace Agent's hasKey with EQL's some.field Sep 10, 2020
@ph ph changed the title [Elastic-Agent] Replace Agent's hasKey with EQL's some.field [Elastic-Agent] Replace Agent's hasKey with EQL's some.field != null Sep 10, 2020
@blakerouse
Copy link
Contributor

We could but that does prevent dynamic access to check for a key in a dictionary. With hasKey you can do hasKey(${output}, ${other.key}), not that I have a specific use-case in mind for that at the moment.

I don't know if currently null is a specific type that can be defined in the condition, but that can easily be changed.

@blakerouse blakerouse self-assigned this Sep 14, 2020
@ph
Copy link
Contributor Author

ph commented Sep 14, 2020

@blakerouse no rush to get that in for 7.10, I see this as a enhancement.

@ph ph added the v7.11.0 label Oct 14, 2020
@blakerouse blakerouse removed their assignment Oct 19, 2021
@jsoriano jsoriano added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 transferred this issue from elastic/beats Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ph @jsoriano @jen-huang @blakerouse @elasticmachine