Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input configs from units should hard-code shipper connection settings #1744

Closed
Tracked by #226 ...
fearful-symmetry opened this issue Nov 17, 2022 · 4 comments
Closed
Tracked by #226 ...

Comments

@fearful-symmetry
Copy link
Contributor

CC @cmacknz
This is similar to #1729

With V2, the shipper is getting a copy of all the inputs for the purpose of configuring GRPC. Right now the logic for this lives in injectShipperConn in pkg/component/runtime/manager_shipper.go. Considering that the shipper needs to make use of that config logic, the struct should be defined in a single place where it can be seen and exported. Ideally, this would be a set of fields in proto.UnitExpectedConfig{}.

@cmacknz
Copy link
Member

cmacknz commented Jan 31, 2023

We spoke about this today.

My opinion is that the problem of defining schemas for configuration sent over the agent control protocol and validating received configuration against it is a general one that affects every process running under agent. I would like to see a solution to this, but the problem is big enough that we shouldn't make solving it a requirement of the shipper project.

We discussed some more targeted ways to improve the way configuration is handled in the shipper without tackling a larger and more general problem:

@pierrehilbert
Copy link
Contributor

@cmacknz / @leehinman could we close this one with the new shipper plan?

@cmacknz
Copy link
Member

cmacknz commented May 4, 2023

This can stay open since it affects the Elastic Agent itself, not the shipper. I have this categorized as technical debt, so we don't need it for any particular release.

@jlind23
Copy link
Contributor

jlind23 commented Jun 5, 2024

The shipper project has been revisited hence closing this as outdated/not relevant.

@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants