Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to yarn workspaces #378

Open
3 of 6 tasks
nickofthyme opened this issue Sep 13, 2019 · 0 comments · Fixed by #1178
Open
3 of 6 tasks

Convert to yarn workspaces #378

nickofthyme opened this issue Sep 13, 2019 · 0 comments · Fixed by #1178
Labels
:build Build tools / dependencies discuss To be discussed enhancement New feature or request

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 13, 2019

Is your feature request related to a problem? Please describe.
Switch to use yarn workspaces.

This would enable to following:

  • Cleaner dependencies in bundled library
  • Separate dependencies for app and library
  • Covert react, etc. to a peerDependency which will improve bundle size and usability.
  • Remove the dependency on node@>10 package.json "engine" is too restrictive #359
  • All your project dependencies will be installed together, giving Yarn more latitude to better optimize them

Tasks

  • Refactor src into packages/elastic-charts/src - build(workspaces): implement src as workspace package #1178
  • Refactor src/utils/d3-delaunay into packages/d3-delaunay
  • Refactor/cleanup src/mocks into respective packages/ or top-level utils. Might consider using a packages/mock-data to store all sample charts mock datasets.
  • Refactor playground into apps/playground
  • Refactor storybook and stories into apps/storybook
  • Refactor storybook-docs into apps/storybook-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:build Build tools / dependencies discuss To be discussed enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants