-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Vislib functional test replacement #794
Comments
Collected the following functions that we used in function tests for area, line and bar charts:
|
@VladLasitsa |
@markov00 |
Completed in elastic/kibana@c88e285 |
Is your feature request related to a problem? Please describe.
The replacement of vislib requires also a replacement of the current functional tests available in Kibana.
These tests are checking also the rendering capabilities inside Kibana picking and analyzing DOM elements.
With the current @elastic/charts library, rendering in Canvas, this is no more possible.
Describe the solution you'd like
PageObject
functions, used by functional tests in Kibana, that are checking values/variables in the DOM rendered by vislib<ChartStatus/>
component as attributes only when thedebug
flag is enableddebug
flag in vislib only when running on the CI (we should be careful here because the debug currently also enable the graphical debug that can break Kibana visual regression tests)PageObject
functions for vislib with similar tests using our exposed statistics/propertiesDescribe alternatives you've considered
Enable Percy on Kibana, but we should define when we want to run it and how
Related issue in Kibana: elastic/kibana#70176
The text was updated successfully, but these errors were encountered: