Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order values by sum causes bad line path #823

Closed
nickofthyme opened this issue Sep 15, 2020 · 1 comment · Fixed by #824
Closed

Order values by sum causes bad line path #823

nickofthyme opened this issue Sep 15, 2020 · 1 comment · Fixed by #824
Assignees
@nickofthyme
Labels
bug Something isn't working released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
Using orderOrdinalBinsBy draws line out of order.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/bar-chart--order-bins-by-sum
  2. Change BarSeries to LineSeries
  3. Ensure orderOrdinalBinsBy in enabled
  4. Notice the line is drawn out of order

Expected behaviour
Draws line in sequential order with orderOrdinalBinsBy setting enabled.

Screenshots
Screen Recording 2020-09-15 at 10 24 AM
@nickofthyme nickofthyme added the bug Something isn't working label Sep 15, 2020
@nickofthyme nickofthyme linked a pull request Sep 17, 2020 that will close this issue
fix: line path with ordered xValues #824
Merged
4 tasks
@nickofthyme nickofthyme mentioned this issue Sep 17, 2020
Merged
4 tasks
@markov00
Copy link
Member

🎉 This issue has been resolved in version 21.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: line path with ordered xValues nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme