Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[field validation] Check values against ECS expected_values #864

Closed
andrewkroh opened this issue Jun 23, 2022 · 2 comments · Fixed by #865
Closed

[field validation] Check values against ECS expected_values #864

andrewkroh opened this issue Jun 23, 2022 · 2 comments · Fixed by #865
Assignees
Labels
enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team

Comments

@andrewkroh
Copy link
Member

ECS added an expected_values list its schema to facilitate data validation. elastic-package should check data against this list when validating documents.

- name: faas
  fields:
    - name: trigger.type
      type: keyword
      expected_values:
        - http
        - pubsub
        - data source
        - timer
        - other
@andrewkroh andrewkroh added the enhancement New feature or request label Jun 23, 2022
@jlind23 jlind23 added the Team:Ecosystem Label for the Packages Ecosystem team label Jun 23, 2022
@jsoriano
Copy link
Member

What is the difference between these expected_values and the list of allowed_values supported in #771?

@andrewkroh
Copy link
Member Author

See the discussion in elastic/ecs#1952 (comment). Basically allowed_values gives the relationship between event.category and event.type while expected_values is a simple list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants