Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo #3

Closed
24 tasks done
ghost opened this issue Sep 26, 2019 · 5 comments
Closed
24 tasks done

ToDo #3

ghost opened this issue Sep 26, 2019 · 5 comments
Labels
meta Overview, roadmap, discussion

Comments

@ghost
Copy link

ghost commented Sep 26, 2019

TODOs

  • Build any beat from cli using packages from artifacts-api.
  • Add beat-specific icon to show up in Add/Remove Programs and MSI.
  • Support for x86 and x64 msi build workflows.
  • Fix quiet install failure (/q, /qn, /q+).
  • Fix administrative install failure (/a).
  • Add support for all build target - builds all known installers. 4cbc102
  • Grab short description of a beat from its README.md file. Dependency removed in 92fa202.
  • Cache used ProductId (guid) -> version map in config.yaml. Deferred.
  • Evaluate switching to "SDK-style" project format for XXXCompiler projects.
  • Create meta-ticket for installer test proces. Connect with Beats team and discuss testing and CI engagement. See Installer Wiki
  • Evaluate using elastic/elasticsearch-net-abstractions to talk to artifacts-api. Elasticsearch Windows MSI package #59
  • Add support for latest, signifying latest version of the artifact (container).
    Might not be trivial: https://github.com/elastic/infra/issues/14645, https://github.com/elastic/infra/issues/5193, Elasticsearch latest not available elasticsearch-docker#215 (comment)
    No action
  • Figure out when to remove the hard-link so that package can be removed from disk. d518199. No Action: existing cleanup behavior removes links.
  • Convert TODO entries to Github issues.

Converted to tickets:

References

@ghost ghost added the meta Overview, roadmap, discussion label Sep 26, 2019
@ghost ghost mentioned this issue Sep 26, 2019
15 tasks
@Mpdreamz
Copy link
Member

Support for distinct x86 and x64 msi build workflows.

Are we okay with just x64 installers? x86 only versions of windows are quite rare nowadays.

@ghost
Copy link
Author

ghost commented Sep 27, 2019

I suspect it's not a big deal at all, as it's controlled by a single switch. If it turns out to be a problem, We'll restrict to x64 only.

@sophiec20
Copy link

sophiec20 commented Sep 30, 2019

I suspect it's not a big deal at all,

It may not be a big deal to flip the switch, but we still have to test, support and maintain x86.

Please only create for x86 if there is a strong need. I do not think this has been established.

@ghost
Copy link
Author

ghost commented Sep 30, 2019

I suspect it's not a big deal at all,

It may not be a big deal to flip the switch, but we still have to test, support and maintain x86.
Please only create for x86 if there is a strong need. I do not this has been established.

Hi @sophiec20, I see. Beats team publishes x86 artifacts, so it was reasonable to support them. I'll mention this in our sync-up with them today. In 85c4208, I just pushed, I defaulted bitness to x64.

UPD: I just spoke with @urso. He mentioned that usage of x86 binaries is quite high, so for now they stay as supported variant. x64 will be default for CLI though.

@ghost
Copy link
Author

ghost commented Mar 25, 2020

Everything is accounted for in tickets and comments

@ghost ghost closed this as completed Mar 25, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Overview, roadmap, discussion
Projects
None yet
Development

No branches or pull requests

2 participants