Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for JavaScript API reference have a typing mismatch for the 'refresh' parameter #1388

Closed
jacoblb64 opened this issue Jan 13, 2021 · 4 comments

Comments

@jacoblb64
Copy link

jacoblb64 commented Jan 13, 2021

🐛 Bug Report

The docs still specify the old type expected, 'true' | 'false' | 'wait_for', where the typing was changed in #1263 to be boolean | 'wait_for'. The docs should be updated to match.

This happens for all of the API endpoints that expect this parameter.

image

To Reproduce

Observe the current API docs at https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/api-reference.html

Expected behavior

The typing to match what the latest client expects


I would try to make the fix myself, but it seems like the docs have a fairly complex generation process, and this seems like it would be a small change for someone familiar with the project.

@delvedor
Copy link
Member

Thank you for reporting!

@saikiransathpadi
Copy link

I would like to work on this. Is this the repo that generates docs as well?

@saikiransathpadi
Copy link

I found the docs folder and looked into it and haven't found this and even didn't found in the reference doc link mentioned above. Can someone confirm whether this is resolved?

@JoshMock
Copy link
Member

I've slowly been tweaking the generated docs over the last couple months to include more and better information about each API function. The bulk API now documents the possible values for refresh accurately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants