From 632d2ddff0ba9bf8d93f644e046d45cfd060d7ed Mon Sep 17 00:00:00 2001 From: Laura Date: Wed, 13 Dec 2023 11:31:07 +0100 Subject: [PATCH 1/4] added note for known typo --- specification/indices/_types/DataStream.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/specification/indices/_types/DataStream.ts b/specification/indices/_types/DataStream.ts index d8f2514853..f32f5d561f 100644 --- a/specification/indices/_types/DataStream.ts +++ b/specification/indices/_types/DataStream.ts @@ -32,7 +32,9 @@ import { DataStreamLifecycleWithRollover } from '@indices/_types/DataStreamLifec enum ManagedBy { /** @codegen_name ilm */ 'Index Lifecycle Management', - /** @codegen_name datastream */ + /** This should have been written with capital letters, it's a known typo and should not be corrected + * since the test cases have already been written + * @codegen_name datastream */ 'Data stream lifecycle', /** @codegen_name unmanaged */ 'Unmanaged' From 91db66f89e1c2e769dfea33cac412f8b281af8f6 Mon Sep 17 00:00:00 2001 From: Laura Date: Wed, 13 Dec 2023 11:31:07 +0100 Subject: [PATCH 2/4] fixed comment structure --- specification/indices/_types/DataStream.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/specification/indices/_types/DataStream.ts b/specification/indices/_types/DataStream.ts index f32f5d561f..c81fe5ee85 100644 --- a/specification/indices/_types/DataStream.ts +++ b/specification/indices/_types/DataStream.ts @@ -32,9 +32,11 @@ import { DataStreamLifecycleWithRollover } from '@indices/_types/DataStreamLifec enum ManagedBy { /** @codegen_name ilm */ 'Index Lifecycle Management', - /** This should have been written with capital letters, it's a known typo and should not be corrected + /** + * This should have been written with capital letters, it's a known typo and should not be corrected * since the test cases have already been written - * @codegen_name datastream */ + * @codegen_name datastream + */ 'Data stream lifecycle', /** @codegen_name unmanaged */ 'Unmanaged' @@ -44,7 +46,8 @@ export class DataStream { /** * Custom metadata for the stream, copied from the `_meta` object of the stream’s matching index template. * If empty, the response omits this property. - * @doc_id mapping-meta-field */ + * @doc_id mapping-meta-field + */ _meta?: Metadata /** * If `true`, the data stream allows custom routing on write request. From 27d0141327b2472e46759d6ee0ee0ac0037e39aa Mon Sep 17 00:00:00 2001 From: Laura Date: Wed, 13 Dec 2023 11:31:07 +0100 Subject: [PATCH 3/4] fixed comment style --- specification/indices/_types/DataStream.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/specification/indices/_types/DataStream.ts b/specification/indices/_types/DataStream.ts index c81fe5ee85..39e62cdf7f 100644 --- a/specification/indices/_types/DataStream.ts +++ b/specification/indices/_types/DataStream.ts @@ -32,11 +32,9 @@ import { DataStreamLifecycleWithRollover } from '@indices/_types/DataStreamLifec enum ManagedBy { /** @codegen_name ilm */ 'Index Lifecycle Management', - /** - * This should have been written with capital letters, it's a known typo and should not be corrected - * since the test cases have already been written - * @codegen_name datastream - */ + /** @codegen_name datastream */ + // This should have been written with capital letters, it's a known typo and should not be corrected, + // since the test cases have already been written 'Data stream lifecycle', /** @codegen_name unmanaged */ 'Unmanaged' From f492ae837b6a77f74201fc5629f3dbe369b03279 Mon Sep 17 00:00:00 2001 From: Laura Date: Wed, 13 Dec 2023 11:31:07 +0100 Subject: [PATCH 4/4] dot --- specification/indices/_types/DataStream.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/indices/_types/DataStream.ts b/specification/indices/_types/DataStream.ts index 39e62cdf7f..dfca2e64d2 100644 --- a/specification/indices/_types/DataStream.ts +++ b/specification/indices/_types/DataStream.ts @@ -34,7 +34,7 @@ enum ManagedBy { 'Index Lifecycle Management', /** @codegen_name datastream */ // This should have been written with capital letters, it's a known typo and should not be corrected, - // since the test cases have already been written + // since the test cases have already been written. 'Data stream lifecycle', /** @codegen_name unmanaged */ 'Unmanaged'