Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Github Edit button opens incorrect file since 6.3 #30883

Closed
jen-huang opened this issue May 25, 2018 · 7 comments
Closed

[Docs] Github Edit button opens incorrect file since 6.3 #30883

jen-huang opened this issue May 25, 2018 · 7 comments
Assignees

Comments

@jen-huang
Copy link

https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-metrics-min-aggregation.html

The min aggregation can also calculate the maximum of a script.
should be
The min aggregation can also calculate the minimum of a script.

In addition, the Edit button doesn't open the right file on master. The same page on 6.2 does however.

@jen-huang jen-huang added the >docs General docs changes label May 25, 2018
@cbuescher
Copy link
Member

@jen-huang thanks for catching this, also I can conform the edit button isn't working the way it should for me either. I will open a quick PR to fix the typo you mentioned and check if the edit button issue is already worked on.

@cbuescher cbuescher added the :Analytics/Aggregations Aggregations label May 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher
Copy link
Member

Opened #30899 for the typo, will change the labeling and title slightly to track the non-working edit buttons

@cbuescher cbuescher changed the title Min aggregation script typo and Edit button opens incorrect file [Docs] Github Edit button opens incorrect file since 6.3 May 28, 2018
@cbuescher cbuescher added :Docs and removed :Analytics/Aggregations Aggregations labels May 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@cbuescher
Copy link
Member

Most of the reference documentations Edit buttons all link to the elasticsearch/x-pack/docs/en/security/securing-communications/tls-ldap.asciidoc page, starting with versions 6.3 it seems.

@cbuescher
Copy link
Member

cbuescher commented May 28, 2018

Git show that most of the broken links got changed by the Docs User bot in elastic/docs@87e587a, so I suspect some slightly earlier changes to be the cause.

@cbuescher
Copy link
Member

@lcawl can you take a look what changed in the build and either correct or reassign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants