Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Cluster alerts need to be updated for hits.total changes #39322

Closed
chrisronline opened this issue Feb 22, 2019 · 7 comments
Closed

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Feb 22, 2019

We need to update the cluster alert watches to handle the hits total changes.

https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/monitoring/src/main/resources/monitoring/watches/elasticsearch_cluster_status.json#L132

@chrisronline chrisronline changed the title [Monitoring] [Monitoring] Cluster alerts need to be updated for hits.total changes Feb 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@chrisronline
Copy link
Contributor Author

cc @elastic/stack-monitoring

@chrisronline
Copy link
Contributor Author

One option here is to change the watcher code to default to the 6.x total format behind a flag and users can manually turn the flag off if they want their watches to respect the 7.x total format

@jakelandis
Copy link
Contributor

One option here is to change the watcher code to default to the 6.x total format behind a flag and users can manually turn the flag off if they want their watches to respect the 7.x total format

@chrisronline - it should already do this. Here is the plan to support the hits.total changes: #36115 (comment) , and #38387.

@chrisronline
Copy link
Contributor Author

Oh nice, so we're good to close this probably @jakelandis?

@jakelandis
Copy link
Contributor

@chrisronline I think so, unless there was an issue you caught, or you wanted to proactively change the internal watches used by monitoring. #38387 is labeled as blocker for 8.0 so we won't forget to address this sometime in the 7.x series.

@chrisronline
Copy link
Contributor Author

Nah, I think those tickets encompass the work as far as I was considering.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants