-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous role resolution change may break stored Authentication objects #57711
Comments
Pinging @elastic/es-security (:Security/Authentication) |
First of all, changes of #53453 can be reverted cleanly on Now after some digging, the behaviour is a bit more involved.
When anonymous roles are relied on to setup and execute things like watchers, it is likley that the entire cluster runs with anonymous Scenario 2, in my opinion, is probably unlikely out there? But this is just my guess, because it does not seem to be a great use of anonymous roles. This setup also has some more difference between
So overall I think the issue is not as bad. But it is an issue nonetheless (behaviour changes including what is previously discussed). Given the revert is straightforward, I am happy to go ahead with it which also buys us some more time to think this through. |
Done revert (#57857) for |
In #53453 we moved the resolution of the anonymous role from authorization time to authentication time.
As a consequence, it is likely that stored
Authentication
headers (as used in Watcher, ML and CCR) may see a change in behaviour.Assume a cluster with the anonymous role set to
superuser
.In 7.7, if user with no other roles authenticated and created a new Watch, we would serialize an
Authentication
object with no roles. When the watch ran we would deserialize that object, but we would run the withsuperuser
privileges because theAuthorizationService
would add the role in automatically.If that same
Authentication
object is deserialized on 7.8, it will have no roles, and will not be granted thesuperuser
role because the anonymous role logic no longer exists in theAuthorizationService
.We intend to revert #53453 and come up with a new solution to the original problem regarding reporting of anonymous roles.
The text was updated successfully, but these errors were encountered: