-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RollupV2 to be more representative of the new RollupAction naming #65621
Comments
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Can I work on this? It's a a good issue |
hi @soarescaique, sure! Just to make it clear, this is not an OSS feature, and these changes will be made in Elastic-licensed code. Feel free to try out a PR and let me know if you have any questions. This is not an urgent task, but it would be nice to have it done soon. For example, I was hoping to do this next week 😄. We appreciate the help! If you're up for it, I'll re-assign it to you |
Sure! I was hoping to it by this weekend. Thank you for the assign. Just to clarify, what would be the best descriptive name to these changes? Since we already have a Rollup class. |
Hi @soarescaique apologies for the delay!
|
After the latest development in the implementation of rollups in the context of a metric database (#74660), this issue is no longer valid. Closing this issue |
#42720 represents an update to Rollups wherein there will exist a dedicated Rollup Action along with a Rollup ILM action. Internally, this was nicknamed RollupV2. There are a few references to this in the codebase
es.rollup_v2_feature_flag_enabled
system propertythese need to drop the V2 to be more descriptive of the final Rollup naming.
The text was updated successfully, but these errors were encountered: