Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RollupV2 to be more representative of the new RollupAction naming #65621

Closed
talevy opened this issue Nov 30, 2020 · 6 comments
Closed
Assignees
Labels
>refactoring :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@talevy
Copy link
Contributor

talevy commented Nov 30, 2020

#42720 represents an update to Rollups wherein there will exist a dedicated Rollup Action along with a Rollup ILM action. Internally, this was nicknamed RollupV2. There are a few references to this in the codebase

  • the rollup/v2 package
  • the RollupV2Indexer
  • the RollupV2 class
  • the es.rollup_v2_feature_flag_enabled system property

these need to drop the V2 to be more descriptive of the final Rollup naming.

@talevy talevy added >refactoring :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 30, 2020
@talevy talevy self-assigned this Nov 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@soarescaique
Copy link

Can I work on this? It's a a good issue

@talevy
Copy link
Contributor Author

talevy commented Dec 1, 2020

hi @soarescaique, sure! Just to make it clear, this is not an OSS feature, and these changes will be made in Elastic-licensed code. Feel free to try out a PR and let me know if you have any questions. This is not an urgent task, but it would be nice to have it done soon. For example, I was hoping to do this next week 😄. We appreciate the help! If you're up for it, I'll re-assign it to you

@soarescaique
Copy link

Sure! I was hoping to it by this weekend. Thank you for the assign. Just to clarify, what would be the best descriptive name to these changes? Since we already have a Rollup class.

@talevy
Copy link
Contributor Author

talevy commented Dec 7, 2020

Hi @soarescaique apologies for the delay!

  • the rollup/v2 package
    • the classes under the /v2 package can be lifted up into the parent directly, in line with the rest of rollup
  • the RollupV2Indexer
    • This can be renamed to RollupActionIndexer
  • the RollupV2 class
    • This can be renamed to RollupAction
  • the es.rollup_v2_feature_flag_enabled system property
    • This can be renamed to es.rollup_action_feature_flag

@talevy talevy assigned csoulios and unassigned talevy Mar 18, 2021
@csoulios
Copy link
Contributor

After the latest development in the implementation of rollups in the context of a metric database (#74660), this issue is no longer valid. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

4 participants