Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report shared_cache shards as zero size on disk #69820

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Mar 2, 2021

Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here, searchable snapshot shards that are using the shared_cache will report 0 as store size.

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Mar 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ywelsch ywelsch merged commit f06dc63 into elastic:master Mar 2, 2021
ywelsch added a commit that referenced this pull request Mar 2, 2021
Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they
report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new
nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here,
searchable snapshot shards that are using the shared_cache will report 0 as store size.
ywelsch added a commit that referenced this pull request Mar 3, 2021
Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they
report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new
nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here,
searchable snapshot shards that are using the shared_cache will report 0 as store size.
henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Mar 22, 2021
With shared cache searchable snapshots we have shards that have a size
in S3 that differs from the locally occupied disk space. This commit
introduces `store.local_size` to node and indices stats, allowing to
differ between the two.

Relates elastic#69820
henningandersen added a commit that referenced this pull request Mar 30, 2021
With shared cache searchable snapshots we have shards that have a size
in S3 that differs from the locally occupied disk space. This commit
introduces `store.total_data_set_size` to node and indices stats, allowing to
differ between the two.

Relates #69820
henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Mar 30, 2021
With shared cache searchable snapshots we have shards that have a size
in S3 that differs from the locally occupied disk space. This commit
introduces `store.total_data_set_size` to node and indices stats, allowing to
differ between the two.

Relates elastic#69820
henningandersen added a commit that referenced this pull request Mar 31, 2021
With shared cache searchable snapshots we have shards that have a size
in S3 that differs from the locally occupied disk space. This commit
introduces `store.total_data_set_size` to node and indices stats, allowing to
differ between the two.

Relates #69820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.12.0 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants