-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report shared_cache shards as zero size on disk #69820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.12.0
v7.13.0
labels
Mar 2, 2021
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Mar 2, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ywelsch
added a commit
that referenced
this pull request
Mar 2, 2021
Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here, searchable snapshot shards that are using the shared_cache will report 0 as store size.
ywelsch
added a commit
that referenced
this pull request
Mar 3, 2021
Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here, searchable snapshot shards that are using the shared_cache will report 0 as store size.
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Mar 22, 2021
With shared cache searchable snapshots we have shards that have a size in S3 that differs from the locally occupied disk space. This commit introduces `store.local_size` to node and indices stats, allowing to differ between the two. Relates elastic#69820
henningandersen
added a commit
that referenced
this pull request
Mar 30, 2021
With shared cache searchable snapshots we have shards that have a size in S3 that differs from the locally occupied disk space. This commit introduces `store.total_data_set_size` to node and indices stats, allowing to differ between the two. Relates #69820
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Mar 30, 2021
With shared cache searchable snapshots we have shards that have a size in S3 that differs from the locally occupied disk space. This commit introduces `store.total_data_set_size` to node and indices stats, allowing to differ between the two. Relates elastic#69820
henningandersen
added a commit
that referenced
this pull request
Mar 31, 2021
With shared cache searchable snapshots we have shards that have a size in S3 that differs from the locally occupied disk space. This commit introduces `store.total_data_set_size` to node and indices stats, allowing to differ between the two. Relates #69820
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.12.0
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searchable snapshot shards that are using the shared_cache are not actually consuming as much disk space as they report today in the "store" section of the node/indices stats. This blocks plan changes on Cloud as they check if the new nodes have enough disk space to host all the (at least primary) shards from the old nodes. With this change here, searchable snapshot shards that are using the shared_cache will report 0 as store size.