-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support of source fallback #88913
Comments
Pinging @elastic/es-search (Team:Search) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
1 is how we used to think but we are more and more departing from it to allow users to do slow things because maybe that's still a better trade-off for them. Good debugging is important indeed. My expectation is that the field usage stats API should already be able to report when an index performs lots of source access as things are today, but it doesn't tell why and how to address it. One thing we discussed a few times is that field usage stats can be used to figure out which index structures are rarely used and could disabled. But we don't have anything that serves the opposite need of figuring out which index structures would be helpful to add on an index because we had to work around the lack of this index structure by doing something less efficient. I wonder if we could add something like that, that would attribute source access to the fields (including runtime fields) that performed this source access with a counter, so that we could build tooling on top of it that would make recommendations for mapping updates. |
Runtime fields already have counts in telemetry around source or doc access (as well as for script-less runtime fields), but these will no longer work once users use the new fields API. I would think it's good info but it's not for debugging purposes. Previously from a script you could already tell whether it accesses source or doc, while now that's transparent hence I think it's a good question, but I am not sure where we would fit that info. Maybe one place could be the profile API.
Nothing changes in _source due to the |
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
The field api has not introduced anything new when it comes to loading from _source, as that was already possible via runtime fields. We have no current plans around improvements in this area. |
#88735 adds infrastructure to support source fallback as part of the new scripting fields API. However, grabbing values from source can be quite expensive which leads to the following questions (credit to @lucabelluccini):
Any thoughts on this @romseygeek, @jpountz, and @javanna ?
The text was updated successfully, but these errors were encountered: