Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

World Subdivisions Layer - outdated ISO 3166-2 codes for CN #172

Open
nickpeihl opened this issue Apr 27, 2020 · 1 comment
Open

World Subdivisions Layer - outdated ISO 3166-2 codes for CN #172

nickpeihl opened this issue Apr 27, 2020 · 1 comment
Labels
data Data related issues and requests

Comments

@nickpeihl
Copy link
Member

It appears the Natural Earth subdivision ISO 3166-2 codes are outdated in China. The ISO 3166-2 codes in China changed from numeric to alpha, e.g. CN-15 -> CN-NM. The GeoIP database also uses the alpha codes so we should update this before releasing.
@nickpeihl nickpeihl added the data Data related issues and requests label Apr 27, 2020
@jsanz
Copy link
Member

jsanz commented Apr 28, 2020

I was wondering if we could run a job to compare our existing layers against this global dataset to flag any other potential misaligns. We can fork Natural Earth vector repo to keep changes, even being all in binary files

@jsanz jsanz mentioned this issue May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data Data related issues and requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsanz @nickpeihl