Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiStat has invalid DOM nesting when isLoading is set to true #2228

Closed
legrego opened this issue Aug 14, 2019 · 2 comments · Fixed by #2229
Closed

EuiStat has invalid DOM nesting when isLoading is set to true #2228

legrego opened this issue Aug 14, 2019 · 2 comments · Fixed by #2229

Comments

@legrego
Copy link
Member

legrego commented Aug 14, 2019

EuiStat has invalid DOM nesting when setting isLoading={true}, due to a <p> tag nested within another <p> tag:

Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.
    in p (created by Context.Consumer)
    in EuiI18n (created by EuiStat)
    in p (created by EuiStat)
    in EuiTitle (created by EuiStat)
    in div (created by EuiStat)
    in EuiStat (created by CopyToSpaceFlyoutFooter)

Reproducer: https://codesandbox.io/s/euistat-invalid-dom-nesting-f33jl

@snide
Copy link
Contributor

snide commented Aug 14, 2019

We'll fix this @legrego. Looks like a good first issue @miukimiu and I can work on tomorrow.

@legrego
Copy link
Member Author

legrego commented Aug 14, 2019

👍 I was just going to take a look, but I'll wait for a fix instead! Thanks @snide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants