-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] bi-directional infinite scrolling #2981
Comments
@chandlerprall Is the required implementation needs to be a custom virtualized scrolling component or by using existing external component like react-virtualized |
react-virtualized doesn't meat our accessibility standards so it's already being ripped out of the existing places that it's in EUI. react-window is a good 3rd party replacement by the same developer that doesn't make any a11y assumptions at all so it's a much easier canvas to layer our a11y work on top of. Either way, using a 3rd party renderer will likely cause problems with DOM work, our focus work, and our keyboard shortcuts... So there be lots of dragons here. |
The datagrid's implementation (react-window or otherwise) will need to interact with the pagination in not-yet-determined ways. Most of the React virtualized scrolling libraries assume all of the data is available, and the windowing functionality is simply passing over the items, rendering whichever should be visible. Datagrid will need more thought than just that, as you may start with a "page" worth of data and then additional requests are necessary while scrolling (potentially both up and down). Imagine a grid of log data, and the default starting point is Any work against this should definitely start with a write-up exploring the problems, options, and a proposed path forward. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
FWIW, I've had some great luck with ReactDataGrid and came to this issue to upvote this story for a "infinite scroll" capability versus the existing "paging" experience. RDG has done a great job with their component. That said I use EUI for most everything in my app and it'd be splendid to have this capability in the EUI grid component. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
We have confirmed that we won't need bidirectional scrolling in the immediate future so closing this issue for now. |
Summarizing a conversation with @weltenwort
Implementation considerations would need to include pinned rows and/or columns.
The text was updated successfully, but these errors were encountered: