Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long EuiComboBox option causes parent EuiFlexItem to wrap #3775

Closed
jen-huang opened this issue Jul 20, 2020 · 2 comments · Fixed by #3968
Closed

Long EuiComboBox option causes parent EuiFlexItem to wrap #3775

jen-huang opened this issue Jul 20, 2020 · 2 comments · Fixed by #3968
Assignees

Comments

@jen-huang
Copy link
Contributor

A long EuiComboBox option seems to cause width issues where its parent EuiFlexItem no longer respects the width constraints imposed on it from EuiFlexGrid/EuiFlexGroup.

Here is a CodeSandbox demo using EuiFlexGroups, the first one is with a short option which causes no wrapping issues. The second uses a long option and you can see that the parent EuiFlexItem wraps into a new row:

image

Example use case in our plugin. For now, I will be fixing this using a calculated max-width on the EuiFlexItem:

Screen Shot 2020-07-20 at 10 22 46 AM

@snide
Copy link
Contributor

snide commented Jul 21, 2020

Thank you for the codesandbox!

This is because the badge it set to a max-width of 100% and the input drops to the second line. Giving the max-width a slightly smaller value, or doing a fancy calc trick against the width of the hidden input will fix it. Shouldn't be too bad to fix.

image

@cchaos
Copy link
Contributor

cchaos commented Jul 23, 2020

@miukimiu Can you take on fixing this one since you were just in that codebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants