-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPopover] has no way to pass data-test-subj
to panel
#4293
Comments
woking on it |
@cchaos Do you have a feeling on which approach is best to take here? Do we just add a I guess to avoid a breaking change, we could also support both things but that might get messy? |
We may just want to support both for now. Meaning, keep the existing panel specific props as they exist, but then extend with |
Might be nice to reorganize all the panel props as a
panelProps
object which could then be spread into the panel so that anything could be passed in.Otherwise, following the current convention, we should add
panelDataTestSubj
I guess?First mentioned in elastic/kibana#83422 (comment)
The text was updated successfully, but these errors were encountered: