Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] has no way to pass data-test-subj to panel #4293

Closed
myasonik opened this issue Nov 20, 2020 · 3 comments · Fixed by #4573
Closed

[EuiPopover] has no way to pass data-test-subj to panel #4293

myasonik opened this issue Nov 20, 2020 · 3 comments · Fixed by #4573

Comments

@myasonik
Copy link
Contributor

Might be nice to reorganize all the panel props as a panelProps object which could then be spread into the panel so that anything could be passed in.

Otherwise, following the current convention, we should add panelDataTestSubj I guess?

First mentioned in elastic/kibana#83422 (comment)

@akashgp09
Copy link
Contributor

woking on it

@myasonik
Copy link
Contributor Author

@cchaos Do you have a feeling on which approach is best to take here?

Do we just add a panelDataTestSubj following the current convention on EuiPopover? Or would it be better to ship a breaking change and pass along a single panelProps object that seems more inline with other components?

I guess to avoid a breaking change, we could also support both things but that might get messy?

@cchaos
Copy link
Contributor

cchaos commented Feb 23, 2021

We may just want to support both for now. Meaning, keep the existing panel specific props as they exist, but then extend with panelProps to encompass all possible props. This way we don't make unnecessary breaking changes since Popovers are everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants