-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSelectable] Add support for Indeterminate values #4668
Comments
@cchaos We don't have styles for handling indeterminate value in EuiSelectable.right!? |
Yeah this is a broader decision that will need to be lead by design. |
Per recent Slack conversations, I wanted to chime in on this issue with some added context regarding the desire to add an indeterminate state to items within the The case for adding an indeterminate stateIn the Kibana issue @jportner references above, a new bulk action will be made available in the saved object management interface. This new bulk action will allow users to share multiple saved objects across multiple spaces. As users attempt to share multiple saved objects, there is a chance that a portion of those selected saved objects have already been shared across one or more spaces. As such, we need a way to indicate this to users. An example of the proposed interface can be seen below: A similar case may also exist in the form of a future enhancement to tag management. Eventually, the hope is to allow users to share multiple tags across multiple spaces via bulk actions (which would also necessitate an indeterminate state if using the Why not use
|
TBH, That's a lot of meaning to put on a simple square icon. I had to read your description to understand the screenshot, when at first glance I had no idea what that icon meant. I think it bears needing a tooltip to give user's this description and therefore, would need to be a custom icon which is what is currently being placed there instead of the internal check icon. So my honest opinion is that it's too vague of an icon to be directly part of the selectable component. But since EuiSelectable supports a completely custom display, you absolutely can attain your desired design by still using that component. |
Yeah, I agree with you that the square icons I used to indicate indeterminate state in those screenshots is too vague. It was my poor attempt at being consistent with the indeterminate state of the |
That's the problem. I can't think of an "appropriate" icon that, in itself, can convey such a unique case without giving the user more feedback as to what it means. I would recommend the custom route because it allows you to wrap your chosen icon in a tooltip to provide that meaningful feedback. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
#1107 added indeterminate values for EuiCheckbox, but EuiSelectable doesn't have an equivalent.
Kibana needs this in elastic/kibana#67380.
The text was updated successfully, but these errors were encountered: