Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup types from EuiMarkdown #4688

Closed
stephmilovic opened this issue Apr 6, 2021 · 4 comments · Fixed by #4746
Closed

Cleanup types from EuiMarkdown #4688

stephmilovic opened this issue Apr 6, 2021 · 4 comments · Fixed by #4746
Assignees

Comments

@stephmilovic
Copy link

We are needing to do some funky typecasting for the EuiMarkdown processingPlugins, see this commit. @chandlerprall said if I make a ticket, Eui team will cleanup. 🙏 😉

@thompsongl
Copy link
Contributor

Hey @stephmilovic, I don't see any type errors when I remove the casting in that (now refactored) file.
No errors in EUI when attempting to replicate either.

@stephmilovic
Copy link
Author

hm, strange. i just confirmed and you're right. closing 🍾

@stephmilovic
Copy link
Author

stephmilovic commented Apr 22, 2021

@thompsongl wait i found it sorry. On the cases_rac_ui branch in Kibana (in a PR against master now). If you comment out the typecast here you will see the error: https://github.com/elastic/kibana/blob/cases_rac_ui/x-pack/plugins/cases/public/components/markdown_editor/use_plugins.ts#L23

@thompsongl
Copy link
Contributor

Ah yep; I see it now. "Exported variable has or is using name from external module but cannot be named"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants