Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCollapsibleNavGroup] background="dark" should be re-written with Emotion colorMode="dark" #6776

Closed
cee-chen opened this issue May 16, 2023 · 0 comments · Fixed by #6865
Closed
Assignees

Comments

@cee-chen
Copy link
Contributor

cee-chen commented May 16, 2023

EuiCollapsibleNavGroup's background="dark" & background="light" props were written 3+ years ago and only really handles setting a background color and not actually setting the correct expected colors on all nested children.

Now that we have Emotion and <EuiThemeProvider colorMode="dark">, we should be able to far more holistically handle this behavior.

This PR may have some overlapping requirements with #6663 and #6759, depending on whether the new Kibana nav design requires a permanently 'dark' UI.

Acceptance criteria

  • EuiCollapsibleNavGroup styles should be rewritten in Emotion. EuiCollapsibleNav as a whole may need to be converted to Emotion as well, depending on how nested its styles are
  • background prop logic should be written using EuiThemeProvider, and prop docs should be updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant