-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSteps] Accessibility Enhancements for EuiSteps
and EuiStepsHorizontal
#6932
Comments
There should be a high contrast styling mix in that we can use to help here. |
Hey @andreadelrio, can you take a look at the first item on this list and let know what you think in terms of design? This halo would only be added to the current step (for both vertical and horizontal steps) and should match the color of the step as well. |
@1Copenut would any of this achieve the a11y objective behind this change? I mocked the halo as inner as well. Outer haloInner halo |
Thank you for these comps @andreadelrio. I'm personally a fan of the outer halo, 2px, because it visually bumps the border out of alignment with the others and becomes a hold that my eye latches onto. I wanted to ask a follow on question about our steps' intent as UI elements. If I understand correctly, the vertical steps where each one is numbered and all are in blue, are used to outline a set of instructions that must be done in order. If that's correct, does it make sense to offer this style here, or reserve it for the horizontal steps only? The docs mention this for horizontal steps:
That's where I feel the different style for the current page makes the most impact, where each step is a link to a new page. Users who are done with 3 of 5 steps, and on step 4 will appreciate seeing those check marks on steps 1, 2, and 3, and the bigger halo around the current step 4 in blue. I hope this makes sense, please ping me if you'd like to discuss in a Zoom chat! |
I think there was a misunderstanding between your initial suggestion |
Thank you both so much! Just to confirm, we will be adding an outer halo of 2px to the current step for both |
Originated from this comment in #6850
There are a few accessibility enhancements to be made with
EuiSteps
andEuiStepsHorizontal
. Each is described below.current
stepProposed solution: Add a halo to the current step that matches its
primary
color. This change should not be applied to any other status.disabled
text color to meet 4:5.1 contrast ratio (for light mode and dark mode)The current coloring of step titles that are disabled do not currently have a good contrast ratio. Let's use a color utility to increase the contrast on the text for better visibility.
The text was updated successfully, but these errors were encountered: