Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiStepsHorizontal should have aria-disabled on steps that users cannot take action #7686

Closed
1Copenut opened this issue Apr 15, 2024 · 2 comments · Fixed by #7699
Closed

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Apr 15, 2024

Describe the problem

The EuiHorizontalSteps component blocks click events when a step is disabled, but allows the button to take keyboard focus. It would be an improvement if the button had a tabindex="-1" to prevent it from taking keyboard focus either while disabled. Screenshot below. an aria-disabled="true" attribute so screen reader users can hear the button in the tabindex, but also be made aware it's not currently available.

WCAG or Vendor Guidance (optional)

Screenshots or Trace Logs

Screenshot 2024-04-18 at 2 55 48 PM
@1Copenut 1Copenut changed the title < EuiStepsHorizontal/> should not allow keyboard focus on disabled steps EuiStepsHorizontal should not allow keyboard focus on disabled steps Apr 15, 2024
@cee-chen
Copy link
Contributor

Would setting aria-disabled on the disabled step suffice? If not, that directive would conflict directly with the goal of #5666.

@1Copenut
Copy link
Contributor Author

Would setting aria-disabled on the disabled step suffice? If not, that directive would conflict directly with the goal of #5666.

Yes it would. I talked with our auditor a bit more and we agreed aria-disabled="true" while still allowing focus, is the right course of action. I'll take this as an action item to update the component and issue a PR.

@1Copenut 1Copenut changed the title EuiStepsHorizontal should not allow keyboard focus on disabled steps EuiStepsHorizontal should have aria-disabled on steps that users cannot take action Apr 18, 2024
@1Copenut 1Copenut self-assigned this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants