Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataset field from logs package #238

Closed
jen-huang opened this issue Aug 6, 2020 · 2 comments
Closed

Remove dataset field from logs package #238

jen-huang opened this issue Aug 6, 2020 · 2 comments
Assignees

Comments

@jen-huang
Copy link
Contributor

With the changes done to change dataset.* fields to data_stream.* in elastic/kibana#74414 and elastic/beats#20420, we should remove the dataset field definition in logs package:

https://github.com/elastic/integrations/blob/master/packages/log/dataset/log/manifest.yml#L19
https://github.com/elastic/integrations/blob/master/packages/log/dataset/log/agent/stream/stream.yml.hbs#L7

While grepping, I found one other instance of a similar field in netflow package, but I'm not sure if this needs to be removed as it's part of ECS fields:
https://github.com/elastic/integrations/blob/master/packages/netflow/dataset/log/fields/ecs.yml#L940

@ruflin ruflin self-assigned this Aug 10, 2020
@ruflin
Copy link
Contributor

ruflin commented Aug 10, 2020

I'm trying to fix this in #234

For the ECS fields in netflow: This is expected.

@jen-huang
Copy link
Contributor Author

Closing as #234 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants