Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle_30974: Ingest pipeline date parsing issue #3318

Merged
merged 6 commits into from
May 17, 2022

Conversation

ishleenk17
Copy link
Contributor

What does this PR do?

This PR parses a 2 digit month day format for the oracle's ingest pipeline

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

The test log file can be changed to a 2 month day. Without the change the particular changed log will not be parsed. With the change, the parsing of the 2 month day will happen successfully.

Related issues

Sorry, something went wrong.

@ishleenk17 ishleenk17 requested review from jsoriano and a team May 10, 2022 14:26
@ishleenk17 ishleenk17 requested a review from a team as a code owner May 10, 2022 14:26
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:57.803+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.597
Classes 100.0% (1/1) 💚 3.597
Methods 100.0% (14/14) 💚 11.753
Lines 89.13% (164/184) 👍 0.018
Conditionals 100.0% (0/0) 💚

…test-oracle-database-audit.log

Co-authored-by: Jaime Soriano Pastor <[email protected]>
@ishleenk17
Copy link
Contributor Author

Yes @jsoriano , it's a single spaces before double digit date. Made the needed change

…test-oracle-database-audit.log-expected.json

Co-authored-by: Jaime Soriano Pastor <[email protected]>
@ishleenk17
Copy link
Contributor Author

/test

@andrewkroh
Copy link
Member

How does this differ from #3337?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Oracle ingest pipeline can't parse date if it's represented by two digit month day
4 participants