-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle_30974: Ingest pipeline date parsing issue #3318
Merged
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
jsoriano
reviewed
May 11, 2022
packages/oracle/data_stream/database_audit/_dev/test/pipeline/test-oracle-database-audit.log
Outdated
Show resolved
Hide resolved
…test-oracle-database-audit.log Co-authored-by: Jaime Soriano Pastor <[email protected]>
Yes @jsoriano , it's a single spaces before double digit date. Made the needed change |
jsoriano
reviewed
May 11, 2022
...e/data_stream/database_audit/_dev/test/pipeline/test-oracle-database-audit.log-expected.json
Outdated
Show resolved
Hide resolved
…test-oracle-database-audit.log-expected.json Co-authored-by: Jaime Soriano Pastor <[email protected]>
/test |
andrewkroh
approved these changes
May 16, 2022
How does this differ from #3337? |
This was referenced May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR parses a 2 digit month day format for the oracle's ingest pipeline
Checklist
changelog.yml
file.How to test this PR locally
The test log file can be changed to a 2 month day. Without the change the particular changed log will not be parsed. With the change, the parsing of the 2 month day will happen successfully.
Related issues