diff --git a/test/functional/page_objects/discover_page.js b/test/functional/page_objects/discover_page.js
index 4654b85f9c7c4..8d12b2117a214 100644
--- a/test/functional/page_objects/discover_page.js
+++ b/test/functional/page_objects/discover_page.js
@@ -283,19 +283,13 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
}
async openSidebarFieldFilter() {
- const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');
- if (!fieldFilterFormExists) {
- await testSubjects.click('toggleFieldFilterButton');
- await testSubjects.existOrFail('discoverFieldFilter');
- }
+ await testSubjects.click('toggleFieldFilterButton');
+ await testSubjects.existOrFail('filterSelectionPanel');
}
async closeSidebarFieldFilter() {
- const fieldFilterFormExists = await testSubjects.exists('discoverFieldFilter');
- if (fieldFilterFormExists) {
- await testSubjects.click('toggleFieldFilterButton');
- await testSubjects.missingOrFail('discoverFieldFilter', { allowHidden: true });
- }
+ await testSubjects.click('toggleFieldFilterButton');
+ await testSubjects.missingOrFail('filterSelectionPanel', { allowHidden: true });
}
}
diff --git a/x-pack/legacy/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.tsx b/x-pack/legacy/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.tsx
index 0c1d20d65b7b9..cfbe8b1edbd71 100644
--- a/x-pack/legacy/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.tsx
+++ b/x-pack/legacy/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.tsx
@@ -12,11 +12,10 @@ import {
RouteProps,
withRouter
} from 'react-router-dom';
-import { StringMap } from '../../../../typings/common';
import { RouteName } from './route_config/route_names';
type LocationMatch = Pick<
- RouteComponentProps
>,
+ RouteComponentProps>,
'location' | 'match'
>;
@@ -75,7 +74,7 @@ export function getBreadcrumb({
return null;
}
- const match = matchPath>(currentPath, route);
+ const match = matchPath>(currentPath, route);
if (match) {
return parse({
diff --git a/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/createErrorGroupWatch.test.ts b/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/createErrorGroupWatch.test.ts
index 4d6c3f4c116c9..c7860b81a7b1e 100644
--- a/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/createErrorGroupWatch.test.ts
+++ b/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/__test__/createErrorGroupWatch.test.ts
@@ -7,7 +7,6 @@
import { isArray, isObject, isString } from 'lodash';
import mustache from 'mustache';
import uuid from 'uuid';
-import { StringMap } from '../../../../../../typings/common';
// @ts-ignore
import * as rest from '../../../../../services/rest/watcher';
import { createErrorGroupWatch } from '../createErrorGroupWatch';
@@ -85,8 +84,11 @@ describe('createErrorGroupWatch', () => {
});
// Recursively iterate a nested structure and render strings as mustache templates
-type InputOutput = string | string[] | StringMap;
-function renderMustache(input: InputOutput, ctx: StringMap): InputOutput {
+type InputOutput = string | string[] | Record;
+function renderMustache(
+ input: InputOutput,
+ ctx: Record
+): InputOutput {
if (isString(input)) {
return mustache.render(input, {
ctx,
diff --git a/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/createErrorGroupWatch.ts b/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/createErrorGroupWatch.ts
index 2617fef6de1d2..e7d06403b8f8e 100644
--- a/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/createErrorGroupWatch.ts
+++ b/x-pack/legacy/plugins/apm/public/components/app/ServiceDetails/ServiceIntegrations/createErrorGroupWatch.ts
@@ -17,7 +17,6 @@ import {
PROCESSOR_EVENT,
SERVICE_NAME
} from '../../../../../common/elasticsearch_fieldnames';
-import { StringMap } from '../../../../../typings/common';
// @ts-ignore
import { createWatch } from '../../../../services/rest/watcher';
@@ -50,8 +49,8 @@ interface Arguments {
interface Actions {
log_error: { logging: { text: string } };
- slack_webhook?: StringMap;
- email?: StringMap;
+ slack_webhook?: Record;
+ email?: Record;
}
export async function createErrorGroupWatch({
diff --git a/x-pack/legacy/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx b/x-pack/legacy/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx
index 8fab7da377eb2..67957ae76b1f1 100644
--- a/x-pack/legacy/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx
+++ b/x-pack/legacy/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx
@@ -22,7 +22,6 @@ import {
import { useFetcher } from '../../../../hooks/useFetcher';
import { useCallApmApi } from '../../../../hooks/useCallApmApi';
import { APMClient } from '../../../../services/rest/createCallApmApi';
-import { StringMap } from '../../../../../typings/common';
import { useKibanaCore } from '../../../../../../observability/public';
const APM_INDEX_LABELS = [
@@ -79,7 +78,7 @@ async function saveApmIndices({
apmIndices
}: {
callApmApi: APMClient;
- apmIndices: StringMap;
+ apmIndices: Record;
}) {
await callApmApi({
method: 'POST',
@@ -95,7 +94,7 @@ export function ApmIndices() {
notifications: { toasts }
} = useKibanaCore();
- const [apmIndices, setApmIndices] = useState>({});
+ const [apmIndices, setApmIndices] = useState>({});
const [isSaving, setIsSaving] = useState(false);
const callApmApiFromHook = useCallApmApi();
diff --git a/x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts b/x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
index cc7697c1d8964..10f59e237ba7f 100644
--- a/x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
+++ b/x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
@@ -17,7 +17,6 @@ import {
} from 'lodash';
import { idx } from '@kbn/elastic-idx';
import { TraceAPIResponse } from '../../../../../../../../server/lib/traces/get_trace';
-import { StringMap } from '../../../../../../../../typings/common';
import { Span } from '../../../../../../../../typings/es_schemas/ui/Span';
import { Transaction } from '../../../../../../../../typings/es_schemas/ui/Transaction';
@@ -191,7 +190,7 @@ function getServices(items: IWaterfallItem[]) {
return uniq(serviceNames);
}
-export type IServiceColors = StringMap;
+export type IServiceColors = Record;
function getServiceColors(services: string[]) {
const assignedColors = [
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/ImpactBar/index.tsx b/x-pack/legacy/plugins/apm/public/components/shared/ImpactBar/index.tsx
index 7f9d3c9f9f3b3..ed931191cfb96 100644
--- a/x-pack/legacy/plugins/apm/public/components/shared/ImpactBar/index.tsx
+++ b/x-pack/legacy/plugins/apm/public/components/shared/ImpactBar/index.tsx
@@ -6,10 +6,9 @@
import { EuiProgress } from '@elastic/eui';
import React from 'react';
-import { StringMap } from '../../../../typings/common';
// TODO: extend from EUI's EuiProgress prop interface
-export interface ImpactBarProps extends StringMap {
+export interface ImpactBarProps extends Record {
value: number;
max?: number;
}
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/Links/url_helpers.ts b/x-pack/legacy/plugins/apm/public/components/shared/Links/url_helpers.ts
index b6caa47d1ae66..357ea23d522a0 100644
--- a/x-pack/legacy/plugins/apm/public/components/shared/Links/url_helpers.ts
+++ b/x-pack/legacy/plugins/apm/public/components/shared/Links/url_helpers.ts
@@ -6,13 +6,12 @@
import qs from 'querystring';
import { LocalUIFilterName } from '../../../../server/lib/ui_filters/local_ui_filters/config';
-import { StringMap } from '../../../../typings/common';
export function toQuery(search?: string): APMQueryParamsRaw {
return search ? qs.parse(search.slice(1)) : {};
}
-export function fromQuery(query: StringMap) {
+export function fromQuery(query: Record) {
return qs.stringify(query, undefined, undefined, {
encodeURIComponent: (value: string) => {
return encodeURIComponent(value).replace(/%3A/g, ':');
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/ManagedTable/index.tsx b/x-pack/legacy/plugins/apm/public/components/shared/ManagedTable/index.tsx
index 0f5fcceea3d20..29a8528295dd7 100644
--- a/x-pack/legacy/plugins/apm/public/components/shared/ManagedTable/index.tsx
+++ b/x-pack/legacy/plugins/apm/public/components/shared/ManagedTable/index.tsx
@@ -8,7 +8,6 @@ import { EuiBasicTable } from '@elastic/eui';
import { sortByOrder } from 'lodash';
import React, { useMemo, useCallback, ReactNode } from 'react';
import { idx } from '@kbn/elastic-idx';
-import { StringMap } from '../../../../typings/common';
import { useUrlParams } from '../../../hooks/useUrlParams';
import { history } from '../../../utils/history';
import { fromQuery, toQuery } from '../Links/url_helpers';
@@ -16,7 +15,7 @@ import { fromQuery, toQuery } from '../Links/url_helpers';
// TODO: this should really be imported from EUI
export interface ITableColumn {
name: ReactNode;
- actions?: StringMap[];
+ actions?: Array>;
field?: string;
dataType?: string;
align?: string;
diff --git a/x-pack/legacy/plugins/apm/public/selectors/chartSelectors.ts b/x-pack/legacy/plugins/apm/public/selectors/chartSelectors.ts
index 4b65190d8ef22..b15231e89365a 100644
--- a/x-pack/legacy/plugins/apm/public/selectors/chartSelectors.ts
+++ b/x-pack/legacy/plugins/apm/public/selectors/chartSelectors.ts
@@ -11,7 +11,6 @@ import mean from 'lodash.mean';
import { rgba } from 'polished';
import { TimeSeriesAPIResponse } from '../../server/lib/transactions/charts';
import { ApmTimeSeriesResponse } from '../../server/lib/transactions/charts/get_timeseries_data/transform';
-import { StringMap } from '../../typings/common';
import {
Coordinate,
RectCoordinate,
@@ -192,7 +191,7 @@ function getColorByKey(keys: string[]) {
const assignedColors = ['HTTP 2xx', 'HTTP 3xx', 'HTTP 4xx', 'HTTP 5xx'];
const unknownKeys = difference(keys, assignedColors);
- const unassignedColors: StringMap = zipObject(unknownKeys, [
+ const unassignedColors: Record = zipObject(unknownKeys, [
theme.euiColorVis1,
theme.euiColorVis3,
theme.euiColorVis4,
diff --git a/x-pack/legacy/plugins/apm/public/services/__test__/SessionStorageMock.ts b/x-pack/legacy/plugins/apm/public/services/__test__/SessionStorageMock.ts
index abe44a0fb3934..83e8f020e2529 100644
--- a/x-pack/legacy/plugins/apm/public/services/__test__/SessionStorageMock.ts
+++ b/x-pack/legacy/plugins/apm/public/services/__test__/SessionStorageMock.ts
@@ -4,10 +4,8 @@
* you may not use this file except in compliance with the Elastic License.
*/
-import { StringMap } from '../../../typings/common';
-
export class SessionStorageMock {
- private store: StringMap = {};
+ private store: Record = {};
public clear() {
this.store = {};
diff --git a/x-pack/legacy/plugins/apm/public/services/rest/xpack.ts b/x-pack/legacy/plugins/apm/public/services/rest/xpack.ts
index 146376665a0e6..95e283cd67709 100644
--- a/x-pack/legacy/plugins/apm/public/services/rest/xpack.ts
+++ b/x-pack/legacy/plugins/apm/public/services/rest/xpack.ts
@@ -5,7 +5,6 @@
*/
import { HttpServiceBase } from 'kibana/public';
-import { StringMap } from '../../../typings/common';
import { callApi } from './callApi';
export interface LicenseApiResponse {
@@ -13,11 +12,11 @@ export interface LicenseApiResponse {
is_active: boolean;
};
features: {
- beats_management?: StringMap;
- graph?: StringMap;
- grokdebugger?: StringMap;
- index_management?: StringMap;
- logstash?: StringMap;
+ beats_management?: Record;
+ graph?: Record;
+ grokdebugger?: Record;
+ index_management?: Record;
+ logstash?: Record;
ml?: {
is_available: boolean;
license_type: number;
@@ -25,12 +24,12 @@ export interface LicenseApiResponse {
enable_links: boolean;
show_links: boolean;
};
- reporting?: StringMap;
- rollup?: StringMap;
- searchprofiler?: StringMap;
- security?: StringMap;
- spaces?: StringMap;
- tilemap?: StringMap;
+ reporting?: Record;
+ rollup?: Record;
+ searchprofiler?: Record;
+ security?: Record;
+ spaces?: Record;
+ tilemap?: Record;
watcher?: {
is_available: boolean;
enable_links: boolean;
diff --git a/x-pack/legacy/plugins/apm/public/utils/httpStatusCodeToColor.ts b/x-pack/legacy/plugins/apm/public/utils/httpStatusCodeToColor.ts
index db1ed490eb7f2..130a7b52ea33b 100644
--- a/x-pack/legacy/plugins/apm/public/utils/httpStatusCodeToColor.ts
+++ b/x-pack/legacy/plugins/apm/public/utils/httpStatusCodeToColor.ts
@@ -5,8 +5,6 @@
*/
import theme from '@elastic/eui/dist/eui_theme_light.json';
-import { StringMap } from '../../typings/common';
-
const { euiColorDarkShade, euiColorWarning } = theme;
export const errorColor = '#c23c2b';
@@ -14,7 +12,7 @@ export const neutralColor = euiColorDarkShade;
export const successColor = '#327a42';
export const warningColor = euiColorWarning;
-const httpStatusCodeColors: StringMap = {
+const httpStatusCodeColors: Record = {
1: neutralColor,
2: successColor,
3: neutralColor,
diff --git a/x-pack/legacy/plugins/apm/server/lib/helpers/es_client.ts b/x-pack/legacy/plugins/apm/server/lib/helpers/es_client.ts
index 84c52b895f20d..ee41599454dd6 100644
--- a/x-pack/legacy/plugins/apm/server/lib/helpers/es_client.ts
+++ b/x-pack/legacy/plugins/apm/server/lib/helpers/es_client.ts
@@ -14,7 +14,6 @@ import {
import { Legacy } from 'kibana';
import { cloneDeep, has, isString, set, pick } from 'lodash';
import { OBSERVER_VERSION_MAJOR } from '../../../common/elasticsearch_fieldnames';
-import { StringMap, Omit } from '../../../typings/common';
import { getApmIndices } from '../settings/apm_indices/get_apm_indices';
import {
ESSearchResponse,
@@ -95,7 +94,7 @@ interface APMOptions {
export function getESClient(req: Legacy.Request) {
const cluster = req.server.plugins.elasticsearch.getCluster('data');
- const query = req.query as StringMap;
+ const query = req.query as Record;
return {
search: async <
diff --git a/x-pack/legacy/plugins/apm/typings/common.ts b/x-pack/legacy/plugins/apm/typings/common.ts
index cfe6c9c572dc4..2fafceb32209c 100644
--- a/x-pack/legacy/plugins/apm/typings/common.ts
+++ b/x-pack/legacy/plugins/apm/typings/common.ts
@@ -4,10 +4,6 @@
* you may not use this file except in compliance with the Elastic License.
*/
-export interface StringMap {
- [key: string]: T;
-}
-
// Allow unknown properties in an object
export type AllowUnknownProperties = T extends Array
? Array>
@@ -24,9 +20,3 @@ export type PromiseReturnType = Func extends (
) => Promise
? Value
: Func;
-
-export type IndexAsString