From 2d42ea9e1c2b72eed0cb92cf5e37870814eee954 Mon Sep 17 00:00:00 2001 From: dej611 Date: Mon, 9 Nov 2020 17:04:18 +0100 Subject: [PATCH] :ok_hand: Apply feedback suggestions --- x-pack/plugins/lens/public/pie_visualization/toolbar.tsx | 2 +- .../plugins/lens/public/shared_components/toolbar_popover.tsx | 4 ++-- .../plugins/lens/public/xy_visualization/xy_config_panel.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx b/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx index ab7422c3eeb63..d69164de8a6aa 100644 --- a/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx +++ b/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx @@ -125,7 +125,7 @@ export function PieToolbar(props: VisualizationToolbarProps diff --git a/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx b/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx index 2d8eb15d6996a..cf2268c6eadf2 100644 --- a/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx +++ b/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx @@ -11,8 +11,8 @@ import { EuiIconLegend } from '../assets/legend'; const typeToIconMap: { [type: string]: string | IconType } = { legend: EuiIconLegend as IconType, - values: 'visText', - numeric: 'number', + labels: 'visText', + values: 'number', }; export interface ToolbarPopoverProps { diff --git a/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx b/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx index ac2e64732f37f..a22530c5743b4 100644 --- a/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx +++ b/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx @@ -262,7 +262,7 @@ export function XyToolbar(props: VisualizationToolbarProps) { title={i18n.translate('xpack.lens.xyChart.valuesLabel', { defaultMessage: 'Values', })} - type="numeric" + type="values" groupPosition="left" buttonDataTestSubj="lnsValuesButton" isDisabled={!isValueLabelsEnabled && !isFittingEnabled}