From fb011fa6a9fb9964c262602b00b56703b5c2d84b Mon Sep 17 00:00:00 2001
From: Jean-Louis Leysens <jloleysens@gmail.com>
Date: Mon, 23 Nov 2020 15:15:00 +0100
Subject: [PATCH] removed configuration context for now

---
 .../configuration_warning_context.tsx         |  48 ---
 .../sections/edit_policy/edit_policy.tsx      | 347 +++++++++---------
 2 files changed, 169 insertions(+), 226 deletions(-)
 delete mode 100644 x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/configuration_warning_context.tsx

diff --git a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/configuration_warning_context.tsx b/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/configuration_warning_context.tsx
deleted file mode 100644
index ae02ccf0843a5..0000000000000
--- a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/configuration_warning_context.tsx
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
- * or more contributor license agreements. Licensed under the Elastic License;
- * you may not use this file except in compliance with the Elastic License.
- */
-
-import React, { FunctionComponent, createContext, useMemo, useContext } from 'react';
-import { get } from 'lodash';
-
-import { useFormData } from '../../../shared_imports';
-
-interface Value {
-  multipleShrinkActions: boolean;
-}
-
-const ConfigurationWarningContext = createContext<Value>(null as any);
-
-const hotShrinkPath = 'phases.hot.actions.shrink.number_of_shards';
-const warmShrinkPath = 'phases.warm.actions.shrink.number_of_shards';
-
-export const ConfigurationWarningProvider: FunctionComponent = ({ children }) => {
-  const [formData] = useFormData({
-    watch: [hotShrinkPath, warmShrinkPath],
-  });
-
-  const configurationWarnings: Value = useMemo(
-    () => ({
-      multipleShrinkActions: get(formData, hotShrinkPath) && get(formData, warmShrinkPath),
-    }),
-    [formData]
-  );
-
-  return (
-    <ConfigurationWarningContext.Provider value={configurationWarnings}>
-      {children}
-    </ConfigurationWarningContext.Provider>
-  );
-};
-
-export const useConfigWarningContext = () => {
-  const ctx = useContext(ConfigurationWarningContext);
-  if (!ctx) {
-    throw new Error(
-      `"useConfigWarningContext" must be used inside of ConfigurationWarningProvider.`
-    );
-  }
-  return ctx;
-};
diff --git a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx b/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
index 719c88fe81204..efa9652e05d84 100644
--- a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
+++ b/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
@@ -47,7 +47,6 @@ import {
 
 import { schema, deserializer, createSerializer, createPolicyNameValidations } from './form';
 import { useEditPolicyContext } from './edit_policy_context';
-import { ConfigurationWarningProvider } from './configuration_warning_context';
 import { FormInternal } from './types';
 
 export interface Props {
@@ -150,198 +149,190 @@ export const EditPolicy: React.FunctionComponent<Props> = ({ history }) => {
 
           <div className="euiAnimateContentLoad">
             <Form form={form}>
-              <ConfigurationWarningProvider>
-                <EuiSpacer size="xs" />
-                <EuiText color="subdued">
-                  <p>
-                    <FormattedMessage
-                      id="xpack.indexLifecycleMgmt.editPolicy.lifecyclePolicyDescriptionText"
-                      defaultMessage="Use an index policy to automate the four phases of the index lifecycle,
+              <EuiSpacer size="xs" />
+              <EuiText color="subdued">
+                <p>
+                  <FormattedMessage
+                    id="xpack.indexLifecycleMgmt.editPolicy.lifecyclePolicyDescriptionText"
+                    defaultMessage="Use an index policy to automate the four phases of the index lifecycle,
                       from actively writing to the index to deleting it."
-                    />{' '}
-                    <LearnMoreLink
-                      docPath="index-lifecycle-management.html"
-                      text={
-                        <FormattedMessage
-                          id="xpack.indexLifecycleMgmt.editPolicy.learnAboutIndexLifecycleManagementLinkText"
-                          defaultMessage="Learn about the index lifecycle."
-                        />
-                      }
-                    />
-                  </p>
-                </EuiText>
+                  />{' '}
+                  <LearnMoreLink
+                    docPath="index-lifecycle-management.html"
+                    text={
+                      <FormattedMessage
+                        id="xpack.indexLifecycleMgmt.editPolicy.learnAboutIndexLifecycleManagementLinkText"
+                        defaultMessage="Learn about the index lifecycle."
+                      />
+                    }
+                  />
+                </p>
+              </EuiText>
 
-                <EuiSpacer />
+              <EuiSpacer />
 
-                {isNewPolicy ? null : (
-                  <Fragment>
-                    <EuiText>
-                      <p>
-                        <strong>
-                          <FormattedMessage
-                            id="xpack.indexLifecycleMgmt.editPolicy.editingExistingPolicyMessage"
-                            defaultMessage="You are editing an existing policy"
-                          />
-                        </strong>
-                        .{' '}
+              {isNewPolicy ? null : (
+                <Fragment>
+                  <EuiText>
+                    <p>
+                      <strong>
                         <FormattedMessage
-                          id="xpack.indexLifecycleMgmt.editPolicy.editingExistingPolicyExplanationMessage"
-                          defaultMessage="Any changes you make will affect the indices that are
+                          id="xpack.indexLifecycleMgmt.editPolicy.editingExistingPolicyMessage"
+                          defaultMessage="You are editing an existing policy"
+                        />
+                      </strong>
+                      .{' '}
+                      <FormattedMessage
+                        id="xpack.indexLifecycleMgmt.editPolicy.editingExistingPolicyExplanationMessage"
+                        defaultMessage="Any changes you make will affect the indices that are
                               attached to this policy. Alternatively, you can save these changes in
                               a new policy."
-                        />
-                      </p>
-                    </EuiText>
-                    <EuiSpacer />
-
-                    <EuiFormRow>
-                      <EuiSwitch
-                        data-test-subj="saveAsNewSwitch"
-                        style={{ maxWidth: '100%' }}
-                        checked={saveAsNew}
-                        onChange={(e) => {
-                          setSaveAsNew(e.target.checked);
-                        }}
-                        label={
-                          <span>
-                            <FormattedMessage
-                              id="xpack.indexLifecycleMgmt.editPolicy.saveAsNewPolicyMessage"
-                              defaultMessage="Save as new policy"
-                            />
-                          </span>
-                        }
                       />
-                    </EuiFormRow>
-                  </Fragment>
-                )}
-
-                {saveAsNew || isNewPolicy ? (
-                  <EuiDescribedFormGroup
-                    title={
-                      <div>
-                        <span className="eui-displayInlineBlock eui-alignMiddle">
+                    </p>
+                  </EuiText>
+                  <EuiSpacer />
+
+                  <EuiFormRow>
+                    <EuiSwitch
+                      data-test-subj="saveAsNewSwitch"
+                      style={{ maxWidth: '100%' }}
+                      checked={saveAsNew}
+                      onChange={(e) => {
+                        setSaveAsNew(e.target.checked);
+                      }}
+                      label={
+                        <span>
                           <FormattedMessage
-                            id="xpack.indexLifecycleMgmt.editPolicy.nameLabel"
-                            defaultMessage="Name"
+                            id="xpack.indexLifecycleMgmt.editPolicy.saveAsNewPolicyMessage"
+                            defaultMessage="Save as new policy"
                           />
                         </span>
-                      </div>
-                    }
-                    titleSize="s"
-                    fullWidth
-                  >
-                    <UseField<string, FormInternal>
-                      path={policyNamePath}
-                      config={{
-                        label: i18n.translate(
-                          'xpack.indexLifecycleMgmt.editPolicy.policyNameLabel',
-                          {
-                            defaultMessage: 'Policy name',
-                          }
-                        ),
-                        helpText: i18n.translate(
-                          'xpack.indexLifecycleMgmt.editPolicy.validPolicyNameMessage',
-                          {
-                            defaultMessage:
-                              'A policy name cannot start with an underscore and cannot contain a question mark or a space.',
-                          }
-                        ),
-                        validations: policyNameValidations,
-                      }}
-                      component={TextField}
-                      componentProps={{
-                        fullWidth: false,
-                        euiFieldProps: {
-                          'data-test-subj': 'policyNameField',
-                        },
-                      }}
+                      }
                     />
-                  </EuiDescribedFormGroup>
-                ) : null}
-
-                <EuiSpacer />
-
-                <HotPhase />
-
-                <EuiHorizontalRule />
-
-                <WarmPhase />
-
-                <EuiHorizontalRule />
-
-                <ColdPhase />
-
-                <EuiHorizontalRule />
-
-                <DeletePhase />
-
-                <EuiHorizontalRule />
-
-                <EuiFlexGroup justifyContent="spaceBetween">
-                  <EuiFlexItem grow={false}>
-                    <EuiFlexGroup>
-                      <EuiFlexItem grow={false}>
-                        <EuiButton
-                          data-test-subj="savePolicyButton"
-                          fill
-                          iconType="check"
-                          iconSide="left"
-                          disabled={form.isValid === false || form.isSubmitting}
-                          onClick={submit}
-                          color="secondary"
-                        >
-                          {saveAsNew ? (
-                            <FormattedMessage
-                              id="xpack.indexLifecycleMgmt.editPolicy.saveAsNewButton"
-                              defaultMessage="Save as new policy"
-                            />
-                          ) : (
-                            <FormattedMessage
-                              id="xpack.indexLifecycleMgmt.editPolicy.saveButton"
-                              defaultMessage="Save policy"
-                            />
-                          )}
-                        </EuiButton>
-                      </EuiFlexItem>
-
-                      <EuiFlexItem grow={false}>
-                        <EuiButtonEmpty
-                          data-test-subj="cancelTestPolicy"
-                          onClick={backToPolicyList}
-                        >
-                          <FormattedMessage
-                            id="xpack.indexLifecycleMgmt.editPolicy.cancelButton"
-                            defaultMessage="Cancel"
-                          />
-                        </EuiButtonEmpty>
-                      </EuiFlexItem>
-                    </EuiFlexGroup>
-                  </EuiFlexItem>
-
-                  <EuiFlexItem grow={false}>
-                    <EuiButtonEmpty onClick={togglePolicyJsonFlyout} data-test-subj="requestButton">
-                      {isShowingPolicyJsonFlyout ? (
+                  </EuiFormRow>
+                </Fragment>
+              )}
+
+              {saveAsNew || isNewPolicy ? (
+                <EuiDescribedFormGroup
+                  title={
+                    <div>
+                      <span className="eui-displayInlineBlock eui-alignMiddle">
                         <FormattedMessage
-                          id="xpack.indexLifecycleMgmt.editPolicy.hidePolicyJsonButto"
-                          defaultMessage="Hide request"
+                          id="xpack.indexLifecycleMgmt.editPolicy.nameLabel"
+                          defaultMessage="Name"
                         />
-                      ) : (
+                      </span>
+                    </div>
+                  }
+                  titleSize="s"
+                  fullWidth
+                >
+                  <UseField<string, FormInternal>
+                    path={policyNamePath}
+                    config={{
+                      label: i18n.translate('xpack.indexLifecycleMgmt.editPolicy.policyNameLabel', {
+                        defaultMessage: 'Policy name',
+                      }),
+                      helpText: i18n.translate(
+                        'xpack.indexLifecycleMgmt.editPolicy.validPolicyNameMessage',
+                        {
+                          defaultMessage:
+                            'A policy name cannot start with an underscore and cannot contain a question mark or a space.',
+                        }
+                      ),
+                      validations: policyNameValidations,
+                    }}
+                    component={TextField}
+                    componentProps={{
+                      fullWidth: false,
+                      euiFieldProps: {
+                        'data-test-subj': 'policyNameField',
+                      },
+                    }}
+                  />
+                </EuiDescribedFormGroup>
+              ) : null}
+
+              <EuiSpacer />
+
+              <HotPhase />
+
+              <EuiHorizontalRule />
+
+              <WarmPhase />
+
+              <EuiHorizontalRule />
+
+              <ColdPhase />
+
+              <EuiHorizontalRule />
+
+              <DeletePhase />
+
+              <EuiHorizontalRule />
+
+              <EuiFlexGroup justifyContent="spaceBetween">
+                <EuiFlexItem grow={false}>
+                  <EuiFlexGroup>
+                    <EuiFlexItem grow={false}>
+                      <EuiButton
+                        data-test-subj="savePolicyButton"
+                        fill
+                        iconType="check"
+                        iconSide="left"
+                        disabled={form.isValid === false || form.isSubmitting}
+                        onClick={submit}
+                        color="secondary"
+                      >
+                        {saveAsNew ? (
+                          <FormattedMessage
+                            id="xpack.indexLifecycleMgmt.editPolicy.saveAsNewButton"
+                            defaultMessage="Save as new policy"
+                          />
+                        ) : (
+                          <FormattedMessage
+                            id="xpack.indexLifecycleMgmt.editPolicy.saveButton"
+                            defaultMessage="Save policy"
+                          />
+                        )}
+                      </EuiButton>
+                    </EuiFlexItem>
+
+                    <EuiFlexItem grow={false}>
+                      <EuiButtonEmpty data-test-subj="cancelTestPolicy" onClick={backToPolicyList}>
                         <FormattedMessage
-                          id="xpack.indexLifecycleMgmt.editPolicy.showPolicyJsonButto"
-                          defaultMessage="Show request"
+                          id="xpack.indexLifecycleMgmt.editPolicy.cancelButton"
+                          defaultMessage="Cancel"
                         />
-                      )}
-                    </EuiButtonEmpty>
-                  </EuiFlexItem>
-                </EuiFlexGroup>
-
-                {isShowingPolicyJsonFlyout ? (
-                  <PolicyJsonFlyout
-                    policyName={saveAsNew ? currentPolicyName : policyName}
-                    close={() => setIsShowingPolicyJsonFlyout(false)}
-                  />
-                ) : null}
-              </ConfigurationWarningProvider>
+                      </EuiButtonEmpty>
+                    </EuiFlexItem>
+                  </EuiFlexGroup>
+                </EuiFlexItem>
+
+                <EuiFlexItem grow={false}>
+                  <EuiButtonEmpty onClick={togglePolicyJsonFlyout} data-test-subj="requestButton">
+                    {isShowingPolicyJsonFlyout ? (
+                      <FormattedMessage
+                        id="xpack.indexLifecycleMgmt.editPolicy.hidePolicyJsonButto"
+                        defaultMessage="Hide request"
+                      />
+                    ) : (
+                      <FormattedMessage
+                        id="xpack.indexLifecycleMgmt.editPolicy.showPolicyJsonButto"
+                        defaultMessage="Show request"
+                      />
+                    )}
+                  </EuiButtonEmpty>
+                </EuiFlexItem>
+              </EuiFlexGroup>
+
+              {isShowingPolicyJsonFlyout ? (
+                <PolicyJsonFlyout
+                  policyName={saveAsNew ? currentPolicyName : policyName}
+                  close={() => setIsShowingPolicyJsonFlyout(false)}
+                />
+              ) : null}
             </Form>
           </div>
         </EuiPageContent>