[Cases] RBAC Bugs

[jonathan-buttner]

This issue is to keep track of the bugs found with the Cases RBAC PR

• Address the warning icon and message that shows up for the Cases sub feature privilege in the roles kibana privilege page (this is part of the security plugin's implementation, it might make sense to not show the warning when the table is expanded) (not fixing this for now)
• Disable the Cases navigation buttons in security solution breadcrumbs and tabs
• Case Details Page ([Cases] RBAC Bugs #101325)
  • Replace permissions callouts with the glasses icon
  • Status badge ([Cases] RBAC Bugs #101325)
    • Keep the color but remove the array and don't allow it to be clicked
  • Remove the sync alerts ([Cases] RBAC Bugs #101325)
  • Remove the 3 dots actions ([Cases] RBAC Bugs #101325)
  • Remove any callouts that the user can't act upon when readonly (editing the external connections etc) ([Cases] RBAC Bugs #101325)
• Case List Page ([Cases] RBAC Bugs #101325)
  • Replace permissions callouts with the glasses icon
  • Remove the create case button and edit connectors when the user is read only ([Cases] RBAC Bugs #101325)
  • Remove the 3 dots actions ([Cases] RBAC Bugs #101325)
• On the overview page, clicking create case when the user doesn't have permissions goes to a blank page (@jonathan-buttner) ([Cases] RBAC Bugs #101325)
  • We no longer allow the user to click on the create case if the user does not have write permissions

Blank page issue

• Hide the attach to cases button within timeline (@jonathan-buttner) ([Cases] RBAC Bugs #101325)

Attaching timeline to cases button should be disabled

• Hide the add to cases icon on the detections page table (@jonathan-buttner) ([Cases] RBAC Bugs #101325)
• Remove the recent cases from the overview page if the user does not have permissions (@jonathan-buttner) ([Cases] RBAC Bugs #101325)
• Remove the add cases button on the overview page if the user only has read permissions (@jonathan-buttner) ([Cases] RBAC Bugs #101325)
• Disabled the status button when a user does not have access to update a case
• Update the wording of the error when a user doesn't have permissions to view a case and tries to access a link.

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[cnasikas]

@jonathan-buttner About the bug with the title, did the RBAC PR introduced it or it is the same on master?

[jonathan-buttner]

@jonathan-buttner About the bug with the title, did the RBAC PR introduced it or it is the same on master?

I tried creating/viewing a case on our dev instance which is off of master and the title was Cases - Kibana so it seems like it's not present on master 🤷‍♂️ I haven't dug into it too deeply though. It's not immediately clear to me how we would have introduced that from the RBAC PR though haha.

[monina-n]

Here is the Figma File for the designs for the different RBAC views (All/Edit, Read, and None).

To summarize:

• For read-only views, take away edit controls and messaging a read-only user cannot act upon

• For no permissions, take away the feature from the main navigation and references to that feature across the app

More detail can be found in the Figma file and in the Cases notes.

[jonathan-buttner]

@MadameSheema the PR for this issue has been merged to master so it's ready for testing!

[MadameSheema]

Thanks @jonathan-buttner :)

@karanbirsingh-qasource can you please take care of this? Thanks :)

[ghost]

sure @MadameSheema

[ghost]

Hi @jonathan-buttner

we have validated all the mentioned issue in this ticket on Master and all the mentioned issue are Fixed ✅ .

However we have a query for two of the points

• S.No 2 Disable the Cases navigation buttons in security solution breadcrumbs and tabs
• S.No 12 Update the wording of the error when a user doesn't have permissions to view a case and tries to access a link

So Can you please look into the shared observation and remark and let us known if that are the correct expected fix or something else.

Build details:

version: 8.0.0-SNAPSHOT
Kibana Build hash:9007199254740991
Elastic Search Build hash:a365bcc42c21f33514d2e4e25a04b36430b68fc4

Observations:

S.No	Issue	Sub-Pointers	Status	Remark	Screen-Cast/Snap-shoot
1	Address the warning icon and message that shows up for the Cases sub feature privilege in the roles kibana privilege page	--	Pass ✔️	Now Warning icon under Case feature only show if user has made any changed under Case Sub-Feature	https://user-images.githubusercontent.com/59917825/123075868-3a843f00-d436-11eb-83f9-5fb565477268.mp4
2	Disable the Cases navigation buttons in security solution breadcrumbs and tabs	--	Query 1 ❓	Case breadcrumb and Case navigation is disabled for case with None Access
3	Case Details Page (#101325)	Replace permissions call-outs with the glasses icon	pass ✔️	glass icon is now showing for Case Sub-feature with Read Access
3a	--	Status badge (#101325) [ Keep the color but remove the array and don't allow it to be ] clicked	Pass ✔️	Status badge is not clickable
3b	--	Remove the sync alerts (#101325)	Pass ✔️	Sync icon not displayed
3c	--	Remove the 3 dots actions (#101325)	Pass ✔️	... icon not displayed
3d	--	Remove any callouts that the user can't act upon when readonly (editing the external connections etc) (#101325)	Pass ✔️	remark
4	Case List Page (#101325)	Replace permissions callouts with the glasses icon	Pass ✔️	remark
4a	--	Remove the create case button and edit connectors when the user is read only (#101325)	Pass ✔️	remark
4b	--	Remove the 3 dots actions (#101325)	Pass ✔️	remark
5	On the overview page, clicking create case when the user doesn't have permissions goes to a blank page (@jonathan-buttner) (#101325)	--	Pass ✔️	Create case link is no longer present for Case Read Access	--
5a	--	We no longer allow the user to click on the create case if the user does not have write permissions	Pass ✔️	Create case link is no longer present for Case Read Access
6	Blank page issue	Hide the attach to cases button within timeline (@jonathan-buttner) (#101325)	Pass ✔️	Attach to case no longer showing ,so user not having link to create case
7	Attaching timeline to cases button should be disabled	-	Pass ✔️	N/A
8	Hide the add to cases icon on the detections page table (@jonathan-buttner) (#101325)	-	Pass ✔️	N/A
9	Remove the recent cases from the overview page if the user does not have permissions (@jonathan-buttner) (#101325)	-	Pass ✔️	N/A
10	Remove the add cases button on the overview page if the user only has read permissions (@jonathan-buttner) (#101325)	-	Pass ✔️	N/A
11	Disabled the status button when a user does not have access to update a case	-	Pass ✔️	N/A
12	Update the wording of the error when a user doesn't have permissions to view a case and tries to access a link.	-	Query 2 ❓	N/A

Queries:

Query1 : Can you please confirm if the right change done for S.No 2 in above observation table

• Cases doesn't exist in the header tabs
• Cases doesn't exist on the sidebar

Query2 :Can you please confirm the wording for S.No 12 , attached snapshot in observation table

thanks !!
c.c @MadameSheema

[jonathan-buttner]

@karanbirsingh-qasource thanks for taking a look.

Queries:
Query1 : Can you please confirm if the right change done for S.No 2 in above observation table

Cases doesn't exist in the header tabs
Cases doesn't exist on the sidebar

Yep! I should have wrote removed instead of disabled, but yes it is the right change.

Query2 :Can you please confirm the wording for S.No 12 , attached snapshot in observation table

Yep! The screenshot is what it should look like 👍

[ghost]

thanks for @jonathan-buttner for providing update.

As all queries are resolved and issues are fixed.

hence closing this ticket and adding QA_Validated to it.