Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Backport Task Manager integration to 7.x #101342

Closed
tsullivan opened this issue Jun 3, 2021 · 3 comments · Fixed by #101447
Closed

[Reporting] Backport Task Manager integration to 7.x #101342

tsullivan opened this issue Jun 3, 2021 · 3 comments · Fixed by #101447
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

tsullivan commented Jun 3, 2021

Kibana version: 7.15

In #64853, we decided not to backport the change from master to 7.x because of the possibility that the user had pending reports that were added to the .reporting index by ESQueue in an earlier 7.x version. Such reports would not get picked up in 8.0 because there would be no corresponding task instance in Task Manager for those jobs.

This is not ideal since it puts a huge delay on the new and improved code from reaching users in a release. Based on the amount of time that Task Manager has been used for Reporting in the dev and test environments, we've seen that the implementation is stable.

We can make the switch to Task Manager into a non-breaking change by updating the data model of .reporting documents and add a new field which will be a keyword of the version of Kibana where the report was queued. In the Task Manager integration, we can search for older reports that are pending and schedule them with Task Manager so they eventually execute.

@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Jun 3, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 3, 2021
@tsullivan tsullivan changed the title [Reporting] a pending reporting task can be accidentally re-scheduled [Reporting] Backport Task Manager integration to 7.x Jun 3, 2021
@tsullivan tsullivan added AppServicesSync-7-14 and removed bug Fixes for quality problems that affect the customer experience labels Jun 3, 2021
@tsullivan
Copy link
Member Author

In the Task Manager integration, we can search for older reports that are pending and schedule them with Task Manager so they eventually execute.

This will be done in the reports:monitor task which is currently responsible for finding reporting jobs that have been in processing status for too long, and need to be rescheduled so they can be retried.

When touching on this code, it will be good to get a re-review of how it works and try to incorporate any lessons about having a monitoring task from the search sessions team.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 5, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 29, 2021
@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants