Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add unit tests for updating top-level fields for preconfigured policies #106606

Closed
jen-huang opened this issue Jul 22, 2021 · 2 comments · Fixed by #107759
Closed

[Fleet] Add unit tests for updating top-level fields for preconfigured policies #106606

jen-huang opened this issue Jul 22, 2021 · 2 comments · Fixed by #107759
Assignees
@hop-dev
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@jen-huang
Copy link
Contributor

In #103722, we made preconfigured policies that are defined in kibana.yml that are managed (ones with is_managed: true) pick up new top-level field changes in kibana.yml.

We should add tests for this case alongside the rest of our unit tests for this feature in https://github.com/elastic/kibana/blob/master/x-pack/plugins/fleet/server/services/preconfiguration.test.ts
@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor Author

@hop-dev assigning this to you following our discussion of helping to improve our tests :)

@jen-huang jen-huang mentioned this issue Jul 22, 2021
Closed
@hop-dev hop-dev mentioned this issue Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hop-dev hop-dev

Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] add unit tests for is_managed agent policy update behaviour hop-dev/kibana
3 participants
@jen-huang @hop-dev @elasticmachine