Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Need unit tests for diagnostic tool #106924

Closed
tsullivan opened this issue Jul 27, 2021 · 3 comments
Closed

[Reporting] Need unit tests for diagnostic tool #106924

tsullivan opened this issue Jul 27, 2021 · 3 comments
Labels
Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Needs Test Cases old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

Currently, there are no tests that check the Reporting diagnostic tool. There recently was a regression bug where refactoring changes broke the buttons in the tool: #106873
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience Team:AppServices labels Jul 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 27, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Aug 18, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 27, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed loe:large Large Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jun 3, 2022
@petrklapka petrklapka added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServicesSv Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:AppServicesUx labels Oct 24, 2022
@vadimkibana vadimkibana added Needs Test Cases and removed bug Fixes for quality problems that affect the customer experience labels Aug 14, 2023
@tsullivan
Copy link
Member Author

My thinking on this has changed since I've written the issue and I don't think we need functional tests for every feature. But, the diagnostic tool also doesn't have any unit tests, so this issue should stay but should be re-titled.

@tsullivan tsullivan changed the title [Reporting/Functional tests] Need functional tests for diagnostic tool [Reporting] Need unit tests for diagnostic tool Aug 1, 2024
@tsullivan tsullivan added Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Aug 1, 2024
@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
@tsullivan
Copy link
Member Author

We have unit tests:

x-pack/platform/plugins/private/reporting/public/management/components/report_diagnostic.test.tsx
x-pack/platform/plugins/private/reporting/server/routes/internal/diagnostic/integration_tests/browser.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Needs Test Cases old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsullivan @elasticmachine @petrklapka @vadimkibana