-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Reduce App Services bundle sizes #112832
Comments
Pinging @elastic/kibana-app-services (Team:AppServices) |
@Dosant was this closed by accident? Exalate is good at that. |
@mattkime No... It was me. I got a little overzealous in cleaning up Jira Epics that were not on our roadmap and I closed it because it had no child tasks. There's plenty to still do on this, so I've re-opened it, set it to show on the roadmap, and we need to attach issues/tasks that it references as children so we can manage the tasking. |
@Dosant is this issue still relevant? Think we can close it in the meanwhile |
Further work is not planned. we can close and reopen when needed |
Initial bundle size of the app services plugins need to get under 100Kb:
data
bundle size #84788Also can be improved:
kibanaUtils
bundle size #114988Further improve kibana react [KibanaReact] ReduceNot app-services anymorekibanaReact
bundle size #114990You can learn why this is important and how to analyze bundle size here https://www.elastic.co/guide/en/kibana/current/plugin-performance.html
One direction how we will approach this is by introducing an "Async registry" concept #65993 which will encourage all registered items to be loaded async. This will not only help app services bundles but will benefit bundles of everyone who adds items to our registries.
Besides taking care of our registries, there are definitely still a bunch of lower-hanging fruits. Things to take care of first:
Suspense
. exampleuiActionsEnhanced
bundle which include handlebars exampleembeddable
plugin includes example samples exampleexport *
to not accidentally re-export not needed code as part of the initial bundletype
) if possible examplelodash
, make sure you import fromlodash
and not fromlodash/*
. That's because full lodash is already included into shared deps.scss
into async chunks together with components. Avoid importing in plugin root.kibana/src/plugins/visualizations/public/embeddable/visualize_embeddable_async.ts
Line 18 in 36e7b5f
The text was updated successfully, but these errors were encountered: