-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle deprecated core API's #119866
Comments
Pinging @elastic/kibana-core (Team:Core) |
Audit results:
Since these deprecations don't have a fixed date for removal (yet), we need to consider if it's worth following through on the deprecations and eventually sunset them or keep the support and remove the deprecation. |
After discussing, we decided the scope here will be:
|
From #121956, we've identified 2 additional APIs that are deprecated but still used. Although TS wouldn't catch it for different reasons:
|
I created #127744 to:
|
A number of core API's were deprecated during the 7.x series and we need to come up with a plan to eventually remove them.
Before we can do that, in the interests of backward compatibility, we need to ensure that the deprecated API's are not being used.
In #77997, we identified the following API's that need to be tracked and monitored for usage:
track and Monitor:
In src/core/server/*:
httpServiceSetup.auth
(useHttpServiceStart.auth
instead) (Remove deprecated & unusedHttpServiceSetup.auth
#127056)IRenderOptions.vars
apparently should have been removed withui_render_mixin
.In src/core/public/*:
CoreSetup.injectedMetadata
(should have been removed when Add config value support in frontend to New Platform #41990 was handled with Expose whitelisted config values to client-side plugin #50641) TL;DR: used to share config between server and client in plugins. Replaced withPluginInitializerContext
CoreStart.injectedMetadata
(should have been removed when Add config value support in frontend to New Platform #41990 was handled with Expose whitelisted config values to client-side plugin #50641) TL;DR: used to share config between server and client in plugins. Replaced withPluginInitializerContext
Scope:
The text was updated successfully, but these errors were encountered: