Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Vega functional tests fail when run against ES 8.0 #123081

Closed
lukeelmers opened this issue Jan 14, 2022 · 1 comment
Closed

[7.17] Vega functional tests fail when run against ES 8.0 #123081

lukeelmers opened this issue Jan 14, 2022 · 1 comment
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.0

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Jan 14, 2022

When testing 7.17 Kibana against 8.0 Elasticsearch, we get some Vega-related failures from CI:

OSS CI Group #11 / visualize app visualize ciGroup11 vega chart in visualize app vega chart initial render should have view and control containers
OSS CI Group #11 / visualize app visualize ciGroup11 vega chart in visualize app vega chart initial render should have view and control containers

https://buildkite.com/elastic/kibana-7-dot-latest-es-8-dot-0-forward-compatibility/builds/15

In 7.17, basic Kibana functions are still expected to work when run against ES 8.0, because during an upgrade process users will upgrade ES first. So we need to identify any failures from these builds and determine if they are simply bugs in our tests, or legit issues that would be 7.17 blockers.

Talking to @flash1293, it sounds like this one might be due to #109090 needing to be backported to 7.17.

To test locally (be sure to update the config paths & string to grep for):

git checkout no-include_type_name
TEST_ES_BRANCH=8.0.0 node scripts/functional_tests_server.js --config=path/to/suite/config.ts
# in another terminal session
node scripts/functional_test_runner --config=path/to/suite/config.ts --grep="whatever"
@lukeelmers lukeelmers added bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.0 labels Jan 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293 flash1293 added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jan 14, 2022
@rudolf rudolf added the blocker label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.0
Projects
None yet
Development

No branches or pull requests

5 participants