Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search.aggs] Support top metric agg in AggConfigs #124535

Closed
10 tasks
Dosant opened this issue Feb 3, 2022 · 1 comment · Fixed by #125936
Closed
10 tasks

[data.search.aggs] Support top metric agg in AggConfigs #124535

Dosant opened this issue Feb 3, 2022 · 1 comment · Fixed by #125936
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@Dosant
Copy link
Contributor

Dosant commented Feb 3, 2022

Part of #60126

This issue tracks support for top metrics aggregation in AggConfigs. Adding this agg type will unblock Lens from supporting these aggs in the future.

  • add new agg type
    • create the agg type
    • export an interface for the agg type's params
    • update AggParamsMapping in types.ts
    • register agg type via agg_types.ts
    • unit tests
  • add agg type expression function
    • write the expression function
    • register expression function via agg_types.ts
    • unit tests
@Dosant Dosant added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:AppServicesSv labels Feb 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant Dosant mentioned this issue Feb 3, 2022
Closed
7 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Feb 3, 2022
@Dosant Dosant mentioned this issue Feb 11, 2022
Closed
@Dosant Dosant mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AggConfigs] Add TopMetrics agg Dosant/kibana
2 participants
@Dosant @elasticmachine