Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Only use Data Views API to load data views #133083

Open
3 of 5 tasks
mattkime opened this issue May 28, 2022 · 4 comments
Open
3 of 5 tasks

[data views] Only use Data Views API to load data views #133083

mattkime opened this issue May 28, 2022 · 4 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@mattkime
Copy link
Contributor

mattkime commented May 28, 2022

Only the Data Views API should perform CRUD related data view operations. The follow UIs are composing their own data view like objects. Instead, they should compose DataViewSpecs and instantiate them with DataViews.create.

  • @elastic/apm-ui - x-pack/plugins/apm/public/components/shared/kuery_bar/index.tsx
  • @elastic/kibana-presentation - x-pack/plugins/canvas/public/lib/es_service.ts
  • @elastic/fleet
    • x-pack/plugins/fleet/server/services/epm/kibana/index_pattern/install.ts
  • @elastic/infra-monitoring-ui - x-pack/plugins/infra/public/containers/with_kuery_autocompletion.tsx
  • @elastic/kibana-vis-editors - x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/math_completion.ts (unifiedSearch.autocomplete.getQuerySuggestions) - [data views][Lens] Only use Data Views API to load data views #133295
@botelastic botelastic bot added the needs-team Issues missing a team label label May 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 28, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jul 21, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Aug 12, 2022
@petrklapka petrklapka added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jul 5, 2023

@mattkime can this be closed, it seems the fleet file does no longer exist, and the info-monitoring-ui issue seems to have ben addressed / refactored away

@kertal
Copy link
Member

kertal commented Jul 5, 2023

ok, seems there's another issue for fleet: #153368

@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@kertal kertal added the technical debt Improvement of the software architecture and operational architecture label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

5 participants