Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Paginating sync requests #135988

Closed
lucasfcosta opened this issue Jul 8, 2022 · 4 comments
Closed

[Synthetics] Paginating sync requests #135988

lucasfcosta opened this issue Jul 8, 2022 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@lucasfcosta
Copy link
Contributor

Summary

Kibana currently syncs all monitors in a single request. That could cause problems if users have way too many monitors, making Kibana exceed the maximum allowed payload size.

We should make sure that Kibana will paginate these sync requests when necessary to avoid reaching that large payload size.

@lucasfcosta lucasfcosta added the bug Fixes for quality problems that affect the customer experience label Jul 8, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 8, 2022
@nickofthyme nickofthyme added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 8, 2022
@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Jan 24, 2023

We already pagination sync requests in groups of 500. We may consider reducing the size of the group to around 100.

Thoughts @andrewvc ?

@andrewvc
Copy link
Contributor

@dominiqueclarke it sounds like @lucasfcosta was mistaken when this issue was made then, is that correct?

If so, I do think that 500 sounds a bit large, I'm just worried about excessive memory usage for larger collections of journeys. Ideally we'd do some tests around memory usage, but we don't have time for that. I'd say lowering it to 100 is probably a good balance of memory and efficiency since this is a background process we're talking about.

@dominiqueclarke
Copy link
Contributor

Resolved by #148634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants