Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Research/POC if AddToTimelinesButton could be a package. #145664

Closed
YulNaumenko opened this issue Nov 18, 2022 · 2 comments
Closed
Assignees
Labels
8.7 candidate Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture

Comments

@YulNaumenko
Copy link
Contributor

YulNaumenko commented Nov 18, 2022

Related to the Epic issue #144943
AddToTimelinesButton are used by the multiple plugins:
Screen Shot 2022-11-17 at 8 24 42 PM

and currently exposed with the timeline plugin as a stateful component.
The goal of the current issue is to make a POC where check if AddToTimelinesButton could be a package with the redux context.
As an example we can use content management table, which is relying on the reducer packages/content-management/table_list/src/table_list_view/reducer.tsx:
https://github.com/elastic/kibana/pull/138244/files

@YulNaumenko YulNaumenko added technical debt Improvement of the software architecture and operational architecture Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore 8.7 candidate labels Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@YulNaumenko
Copy link
Contributor Author

YulNaumenko commented Jan 12, 2023

Solved by the PR #146779. For now we changed the direction to keep it as a part of security_solution plugin and build the availability to other plugins through the uiActions sharing capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7 candidate Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants