Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] large field caps responses can block main thread, reducing responsiveness #151249

Closed
mattkime opened this issue Feb 15, 2023 · 4 comments
Closed

[data views] large field caps responses can block main thread, reducing responsiveness #151249

mattkime opened this issue Feb 15, 2023 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mattkime
Copy link
Contributor

mattkime commented Feb 15, 2023 •
edited
Loading

Lets use https://loaders.gl/modules/json/docs/api-reference/json-loader#usage to load the field list. Its used by maps here - x-pack/plugins/file_upload/public/importer/geo/geojson_importer/geojson_importer.ts#L39 . This will improve browser responsiveness when loading a large field list and more importantly it will make the kibana server more resilient when loading large field lists.

Part of #151064
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 15, 2023
@kertal
Copy link
Member

kertal commented Feb 15, 2023

Could you provide some details how this approach could be integrated in data view field loading? Thx! So the JSON returned from ES should be parsed in patches?

@davismcphee davismcphee added enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 15, 2023
@mattkime mattkime mentioned this issue Feb 28, 2023
Merged
1 task
@mattkime
Copy link
Contributor Author

So the JSON returned from ES should be parsed in patches?

That's generally the idea. At this point I don't see this as being worth pursuing due to #152159

@kertal kertal mentioned this issue Jun 20, 2023
Closed
@kertal
Copy link
Member

kertal commented Jul 5, 2023

@mattkime 🧹 action, can we close in favor of #152159 ? thx

@mattkime mattkime closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattkime @kertal @elasticmachine @davismcphee