[ML] Remove static api service #153477
Labels
Meta
:ml
refactoring
technical debt
Improvement of the software architecture and operational architecture
v8.16.0
Comments
jgowdyelastic
added
Meta
:ml
refactoring
technical debt
|
Pinging @elastic/ml-ui (:ml) |
59 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The statically imported api service, normally imported as
mlfromml/public/application/services/ml_api_service/index.tsuseshttpfrom the dependency cache.This statically imported server should be removed.
In some cases
mlisn't used, and a more specific provider is used instead, e.g.jobsApiProviderTypeScript react functional components
Replace with context versions supplied by
useMlApiContextor specific hooks likeuseTrainedModelsApiService(do we need specific hooks like this? only ever usinguseMlApiContextwould be simpler and easier to document.alerting/job_selector.tsxalerting/preview_alert_condition.tsxalerting/jobs_health_rule/anomaly_detection_jobs_health_rule_trigger.tsxalerting/ml_anomaly_alert_trigger.tsxapplication/settings/anomaly_detection_settings.tsxapplication/app.tsxapplication/management/jobs_list/components/jobs_list_page/space_management/space_management.tsxapplication/management/jobs_list/components/jobs_list_page/jobs_list_page.tsxapplication/components/model_snapshots/edit_model_snapshot_flyout/edit_model_snapshot_flyout.tsxapplication/components/model_snapshots/model_snapshots_table.tsxapplication/components/model_snapshots/revert_model_snapshot_flyout/revert_model_snapshot_flyout.tsxapplication/components/jobs_awaiting_node_warning/new_job_awaiting_node_shared/new_job_awaiting_node_shared.tsxapplication/components/annotations/annotation_flyout/index.tsxapplication/components/anomalies_table/anomaly_details.tsxapplication/components/anomalies_table/links_menu.tsxapplication/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsxapplication/data_frame_analytics/pages/analytics_creation/components/create_analytics_advanced_editor/create_analytics_advanced_editor.tsxapplication/data_frame_analytics/pages/analytics_creation/components/create_step_footer/create_step_footer.tsxapplication/data_frame_analytics/pages/analytics_creation/page.tsxapplication/data_frame_analytics/pages/analytics_exploration/components/expandable_section/expandable_section_analytics.tsxapplication/data_frame_analytics/pages/analytics_management/components/action_edit/edit_action_flyout.tsxapplication/data_frame_analytics/pages/analytics_management/components/analytics_list/expanded_row_messages_pane.tsxapplication/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsxapplication/routing/routes/explorer.tsxapplication/routing/routes/timeseriesexplorer.tsxapplication/jobs/new_job/pages/components/validation_step/validation.tsxapplication/jobs/new_job/pages/components/job_details_step/components/additional_section/components/calendars/calendars_selection.tsxapplication/jobs/new_job/pages/components/pick_fields_step/components/categorization_view/top_categories.tsxapplication/jobs/new_job/pages/components/pick_fields_step/components/categorization_view/category_stopped_partitions.tsxapplication/jobs/jobs_list/components/job_details/job_messages_pane.tsxapplication/overview/components/analytics_panel/analytics_panel.tsxapplication/overview/components/anomaly_detection_panel/anomaly_detection_panel.tsxapplication/memory_usage/nodes_overview/nodes_list.tsxapplication/memory_usage/memory_tree_map/tree_map.tsxapplication/model_management/delete_models_modal.tsxapplication/model_management/models_list.tsxapplication/model_management/test_models/test_flyout.tsxapplication/model_management/model_actions.tsxmaps/anomaly_layer_wizard_factory.tsxmaps/anomaly_source.tsxmaps/anomaly_job_selector.tsxmaps/create_anomaly_source_editor.tsxUtil like files, hooks, services
These will need to be wrapped in provider function or converted to a service class to allow the dependencies to be passed in.
application/capabilities/check_capabilities.tsapplication/capabilities/get_capabilities.tsapplication/components/import_export_jobs/export_jobs_flyout/jobs_export_service.tsapplication/components/node_available_warning/hooks.tsapplication/components/rule_editor/utils.jsapplication/data_frame_analytics/common/analytics.tsapplication/data_frame_analytics/common/get_index_data.tsapplication/data_frame_analytics/common/use_results_view_config.tsapplication/data_frame_analytics/pages/analytics_creation/components/shared/fetch_explain_data.tsapplication/data_frame_analytics/pages/analytics_creation/hooks/use_index_data.tsapplication/data_frame_analytics/pages/analytics_exploration/components/exploration_results_table/use_exploration_results.tsapplication/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/use_create_analytics_form.tsapplication/data_frame_analytics/pages/analytics_management/services/analytics_service/delete_analytics.tsapplication/data_frame_analytics/pages/analytics_management/services/analytics_service/get_analytics.tsapplication/data_frame_analytics/pages/analytics_management/services/analytics_service/start_analytics.tsapplication/data_frame_analytics/pages/analytics_management/services/analytics_service/stop_analytics.tsapplication/data_frame_analytics/pages/job_map/use_fetch_analytics_map_data.tsapplication/explorer/explorer_utils.tsapplication/jobs/components/custom_url_editor/utils.jsapplication/jobs/jobs_list/components/edit_job_flyout/edit_utils.jsapplication/jobs/jobs_list/components/utils.jsapplication/jobs/new_job/common/chart_loader/chart_loader.tsapplication/jobs/new_job/common/chart_loader/searches.tsapplication/jobs/new_job/common/job_creator/job_creator.tsapplication/jobs/new_job/common/job_creator/util/model_memory_estimator.tsapplication/jobs/new_job/common/job_runner/job_runner.tsapplication/jobs/new_job/common/job_validator/validators.tsapplication/jobs/new_job/common/results_loader/categorization_examples_loader.tsapplication/jobs/new_job/common/results_loader/searches.tsapplication/jobs/new_job/job_from_dashboard/quick_create_job_base.tsapplication/jobs/new_job/job_from_lens/quick_create_job.tsapplication/jobs/new_job/job_from_lens/route_resolver.tsapplication/jobs/new_job/job_from_map/quick_create_job.tsapplication/jobs/new_job/job_from_map/route_resolver.tsapplication/jobs/new_job/pages/components/pick_fields_step/components/bucket_span_estimator/estimate_bucket_span.tsapplication/jobs/new_job/recognize/resolvers.tsapplication/ml_nodes_check/check_ml_nodes.tsapplication/model_management/test_models/models/inference_base.tsapplication/model_management/test_models/models/ner/ner_inference.tsapplication/model_management/test_models/models/question_answering/question_answering_inference.tsapplication/model_management/test_models/models/text_classification/fill_mask_inference.tsapplication/model_management/test_models/models/text_classification/lang_ident_inference.tsapplication/model_management/test_models/models/text_classification/text_classification_inference.tsapplication/model_management/test_models/models/text_classification/zero_shot_classification_inference.tsapplication/model_management/test_models/models/text_embedding/text_embedding_inference.tsapplication/services/anomaly_detector_service.tsapplication/services/anomaly_explorer_charts_service.tsapplication/services/calendar_service.tsapplication/services/forecast_service.jsapplication/services/job_service.jsapplication/services/mapping_service.jsapplication/services/ml_server_info.tsapplication/services/new_job_capabilities/new_job_capabilities_service_analytics.tsapplication/services/new_job_capabilities/new_job_capabilities_service.tsapplication/services/results_service/index.tsapplication/services/results_service/result_service_rx.tsapplication/services/results_service/results_service.d.tsapplication/settings/calendars/edit/utils.jsapplication/settings/filter_lists/edit/utils.jsapplication/timeseriesexplorer/timeseries_search_service.tsapplication/timeseriesexplorer/timeseriesexplorer_utils/get_focus_data.tsembeddables/anomaly_charts/anomaly_charts_embeddable_factory.tsembeddables/anomaly_swimlane/anomaly_swimlane_embeddable_factory.tsmaps/anomaly_source_factory.tsmaps/util.tsReact classes
Convert to functional component to allow use of
useMlApiContextor pass in specific api dependencies as props.An alternative is to use
contextTypeto access kibana context from the class based component (see https://legacy.reactjs.org/docs/context.html#classcontexttype).For javascript files, converting to a functional component would also involve rewriting in TypeScript.
application/components/annotations/annotations_table/annotations_table.jsapplication/components/anomalies_table/anomalies_table.jsapplication/components/data_recognizer/data_recognizer.jsapplication/components/rule_editor/rule_editor_flyout.jsapplication/components/rule_editor/select_rule_action/rule_action_panel.jsapplication/datavisualizer/index_based/data_loader/data_loader.tsapplication/jobs/jobs_list/components/edit_job_flyout/edit_job_flyout.jsapplication/jobs/jobs_list/components/edit_job_flyout/tabs/job_details.jsapplication/jobs/jobs_list/components/job_details/datafeed_preview_tab.jsapplication/jobs/jobs_list/components/jobs_list_view/jobs_list_view.jsapplication/jobs/jobs_list/components/multi_job_actions/group_selector/group_selector.jsapplication/settings/calendars/edit/new_calendar.jsapplication/settings/calendars/list/calendars_list.jsapplication/settings/calendars/list/delete_calendars.jsapplication/settings/filter_lists/components/delete_filter_list_modal/delete_filter_lists.jsapplication/settings/filter_lists/edit/edit_filter_list.jsapplication/settings/filter_lists/list/filter_lists.jsapplication/timeseriesexplorer/components/forecasting_modal/forecasting_modal.jsapplication/timeseriesexplorer/timeseriesexplorer.jsTest files
application/components/annotations/annotations_table/annotations_table.test.jsapplication/components/ml_entity_selector/ml_entity_selector.test.tsxapplication/components/rule_editor/rule_editor_flyout.test.jsapplication/components/rule_editor/select_rule_action/rule_action_panel.test.jsapplication/contexts/kibana/__mocks__/kibana_context.tsapplication/contexts/kibana/__mocks__/use_ml_api_context.tsapplication/data_frame_analytics/pages/analytics_management/services/analytics_service/get_analytics.test.tsapplication/jobs/new_job/common/job_creator/util/model_memory_estimator.test.tsapplication/services/anomaly_explorer_charts_service.test.tsapplication/services/ml_server_info.test.tsapplication/services/new_job_capabilities/new_job_capabilities._service.test.tsapplication/settings/calendars/edit/new_calendar.test.jsapplication/settings/calendars/list/calendars_list.test.jsapplication/settings/filter_lists/components/delete_filter_list_modal/delete_filter_list_modal.test.jsapplication/settings/filter_lists/edit/edit_filter_list.test.jsapplication/settings/filter_lists/list/filter_lists.test.jsapplication/settings/filter_lists/list/table.test.jsThe text was updated successfully, but these errors were encountered: