Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark background for the side nav #154492

Closed
tsullivan opened this issue Apr 5, 2023 · 5 comments
Closed

Dark background for the side nav #154492

tsullivan opened this issue Apr 5, 2023 · 5 comments
Assignees
@tsullivan
Labels
Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

The new side-navigation bar for serverless deployments will feature a dark background behind the menu items. The EUI components that are the building blocks for the navigation must natively support dark mode and the dark mode abilities must be turned on in the Kibana navigation component.
@tsullivan
Copy link
Member Author

Depends on elastic/eui#6663

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 5, 2023
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 5, 2023
@tsullivan tsullivan added the Project:Serverless Work as part of the Serverless project for its initial release label Apr 5, 2023
@tsullivan
Copy link
Member Author

I just saw the latest activity in elastic/eui#6663 and there is a workaround suggested. No longer blocked.

@tsullivan tsullivan added the Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) label May 6, 2023
@tsullivan
Copy link
Member Author

Let's get the latest feedback from design

@tsullivan
Copy link
Member Author

This functionality is expected to be provided in upcoming EUI component updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsullivan tsullivan

Labels
Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsullivan @elasticmachine