Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "experimental" banner collapsable/hidable. #15713

Closed
nyurik opened this issue Dec 20, 2017 · 9 comments
Closed

Make "experimental" banner collapsable/hidable. #15713

nyurik opened this issue Dec 20, 2017 · 9 comments
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@nyurik
Copy link
Contributor

nyurik commented Dec 20, 2017

The experimental banner takes up considerable screen real estate, without being able to collapse/hide it.
image

@nyurik nyurik assigned nyurik and timroes and unassigned nyurik Dec 20, 2017
@alexfrancoeur alexfrancoeur added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Dec 20, 2017
@alexfrancoeur
Copy link

@snide @cjcenizal @cchaos I'd like your feedback here. We'd like to reduce the amount of space for the warning we present for lab visualizations. Not only that, but is there a better way we can style it? I know the ask here is to make the banner collapsable, but I'm wondering if we reduce the amount of space being used if it's still necessary.

cc: @thomasneirynck

@timroes timroes removed their assignment Dec 21, 2017
@thomasneirynck
Copy link
Contributor

I agree just making it smaller would be enough imho

@alexfrancoeur
Copy link

++ maybe we can sneak this into 6.2?

@cjcenizal
Copy link
Contributor

Can this be surfaced using notify.info() without a timer? Then it will show up at the top of the screen as a blue banner and the user can dismiss it. As we start integrating EuiToast to replace most of our banner notifications, the banner notifications may become more appropriate for this kind of use case.

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2018

I would just suggest switching to use the euiCallOut component with only a header. It only reduces the spacing a little bit, but the styling allows for a quick skim and skip over if it's a recognizable message.

I'd also suggest adding the experimental icon fa-flask (for now until a custom icon is created for that) to the message.

screen shot 2018-01-08 at 14 05 28 pm

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2018

I'm just seeing @cjcenizal's comment. That could work as well, but if you just want a quick component swap, you could go with the euiCallOut.

It's also worth considering if this is something that should be dismiss-able at all, or at least user-dismissed vs auto-dismissed.

@timroes
Copy link
Contributor

timroes commented Jan 8, 2018

I like the euiCallOut one. Do you think we could create a modified version of euiCallOut--condense, that would have less padding? We could of course also overwrite the padding just for this one, but I would rather - if you think it makes sense - have this as a common class in EUI.

I would vote against the info notification, since I think they are (the way they currently behave) a huge disturbance for the user and offer bad usability (they can stay when changing the screen, but doesn't need to, sometimes I see a banner up, and am not sure if it just appeared again, or is the one from earlier, etc.). So I would rather go with euiCallOut.

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2018

We can do that. I'll update the component to add a paddingSize prop.

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2018

There is now a small version of the EuiCallOut available.

elastic/eui#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

6 participants