Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Fix console ":first-child is potentially unsafe" error for the new threshold rule #162867

Closed
maryam-saeidi opened this issue Aug 1, 2023 · 5 comments
Assignees
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 1, 2023

📝 Summary

When creating a new threshold rule, by changing the aggregation, we get this error in the developer console:

The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type". 
    at Insertion (http://localhost:5601/kibana/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161609:20)
    at http://localhost:5601/kibana/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161448:73
    at EuiTextColor (http://localhost:5601/kibana/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:144970:23)
    at EuiText (http://localhost:5601/kibana/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:144691:24)
    at div
    at ExpressionChart 

image

✅ Acceptance Criteria

  • Fix the error mentioned above in the browser console
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Aug 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@stephmilovic
Copy link
Contributor

I see this error on page load, on every page. Could be related to Eui changes?

@maryam-saeidi
Copy link
Member Author

Good point!

@maryam-saeidi
Copy link
Member Author

It seems this PR should fix it.

@maryam-saeidi
Copy link
Member Author

It is fixed 🎉

@maryam-saeidi maryam-saeidi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Projects
None yet
Development

No branches or pull requests

4 participants